This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Add option enable-buffer-initialization to the sparse-tensor-codegen pass.
ClosedPublic

Authored by bixia on Nov 9 2022, 12:40 PM.

Diff Detail

Event Timeline

bixia created this revision.Nov 9 2022, 12:40 PM
Herald added a project: Restricted Project. · View Herald Transcript
bixia requested review of this revision.Nov 9 2022, 12:40 PM

Can we add a check test for this. Preferably just a separate one (I mean not intermixed with codegen.mlir)?

bixia updated this revision to Diff 474376.Nov 9 2022, 3:12 PM

Add a FileCheck test.

aartbik accepted this revision.Nov 9 2022, 3:18 PM
aartbik added inline comments.
mlir/test/Dialect/SparseTensor/codegen_buffer_initialization.mlir
15 ↗(On Diff #474376)

indentation of 3x CHECK on linalg.fill?

32 ↗(On Diff #474376)

newline?

This revision is now accepted and ready to land.Nov 9 2022, 3:18 PM
bixia updated this revision to Diff 474379.Nov 9 2022, 3:26 PM
bixia marked an inline comment as done.

Fix test file format.

bixia marked an inline comment as done.Nov 9 2022, 3:27 PM
bixia updated this revision to Diff 474387.Nov 9 2022, 4:17 PM

Fix test.

bixia updated this revision to Diff 474395.Nov 9 2022, 5:07 PM

Fix the constructor.