This is an archive of the discontinued LLVM Phabricator instance.

Differential D137729

[libc++] Add FTM for constexpr vector
ClosedPublic

Authored by philnik on Nov 9 2022, 12:02 PM.

Details

Reviewers
ldionne
Mordante
var-const
huixie90
Group Reviewers
Restricted Project
Commits
rGb7c0a4065e32: [libc++] Add FTM for constexpr vector
Summary

It looks like we forgot to set the FTM when adding constexpr vector support.

Diff Detail

Event Timeline

philnik created this revision.Nov 9 2022, 12:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2022, 12:02 PM
Herald added a subscriber: arichardson. · View Herald Transcript
philnik requested review of this revision.Nov 9 2022, 12:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2022, 12:02 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne accepted this revision.Nov 9 2022, 12:06 PM
This revision is now accepted and ready to land.Nov 9 2022, 12:06 PM
Harbormaster completed remote builds in B196936: Diff 474326.Nov 9 2022, 1:18 PM
Closed by commit rGb7c0a4065e32: [libc++] Add FTM for constexpr vector (authored by philnik). · Explain WhyNov 9 2022, 1:45 PM
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rGb7c0a4065e32: [libc++] Add FTM for constexpr vector.

Revision Contents

PathSize
libcxx/
docs/
2 lines
include/
2 lines
test/
std/
language.support/
support.limits/
support.limits.general/
32 lines
32 lines
utils/
1 line

Diff 474351

libcxx/docs/FeatureTestMacroTable.rst

Show First 20 Lines • Show All 216 Lines • ▼ Show 20 Lines.. table:: Current Status
``__cpp_lib_constexpr_string`` ``201907L`` ``__cpp_lib_constexpr_string`` ``201907L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_constexpr_string_view`` ``201811L`` ``__cpp_lib_constexpr_string_view`` ``201811L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_constexpr_tuple`` ``201811L`` ``__cpp_lib_constexpr_tuple`` ``201811L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_constexpr_utility`` ``201811L`` ``__cpp_lib_constexpr_utility`` ``201811L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_constexpr_vector`` *unimplemented* ``__cpp_lib_constexpr_vector`` ``201907L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_coroutine`` ``201902L`` ``__cpp_lib_coroutine`` ``201902L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_destroying_delete`` ``201806L`` ``__cpp_lib_destroying_delete`` ``201806L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_endian`` ``201907L`` ``__cpp_lib_endian`` ``201907L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_erase_if`` ``202002L`` ``__cpp_lib_erase_if`` ``202002L``
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines

libcxx/include/version

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines
# define __cpp_lib_constexpr_functional 201907L # define __cpp_lib_constexpr_functional 201907L
# define __cpp_lib_constexpr_iterator 201811L # define __cpp_lib_constexpr_iterator 201811L
# define __cpp_lib_constexpr_memory 201811L # define __cpp_lib_constexpr_memory 201811L
# define __cpp_lib_constexpr_numeric 201911L # define __cpp_lib_constexpr_numeric 201911L
# define __cpp_lib_constexpr_string 201907L # define __cpp_lib_constexpr_string 201907L
# define __cpp_lib_constexpr_string_view 201811L # define __cpp_lib_constexpr_string_view 201811L
# define __cpp_lib_constexpr_tuple 201811L # define __cpp_lib_constexpr_tuple 201811L
# define __cpp_lib_constexpr_utility 201811L # define __cpp_lib_constexpr_utility 201811L
// # define __cpp_lib_constexpr_vector 201907L # define __cpp_lib_constexpr_vector 201907L
# define __cpp_lib_coroutine 201902L # define __cpp_lib_coroutine 201902L
# if _LIBCPP_STD_VER > 17 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L # if _LIBCPP_STD_VER > 17 && defined(__cpp_impl_destroying_delete) && __cpp_impl_destroying_delete >= 201806L
# define __cpp_lib_destroying_delete 201806L # define __cpp_lib_destroying_delete 201806L
# endif # endif
# define __cpp_lib_endian 201907L # define __cpp_lib_endian 201907L
# define __cpp_lib_erase_if 202002L # define __cpp_lib_erase_if 202002L
# undef __cpp_lib_execution # undef __cpp_lib_execution
// # define __cpp_lib_execution 201902L // # define __cpp_lib_execution 201902L
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines

libcxx/test/std/language.support/support.limits/support.limits.general/vector.version.compile.pass.cpp

Show First 20 Lines • Show All 117 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_allocator_traits_is_always_equal # ifndef __cpp_lib_allocator_traits_is_always_equal
# error "__cpp_lib_allocator_traits_is_always_equal should be defined in c++20" # error "__cpp_lib_allocator_traits_is_always_equal should be defined in c++20"
# endif # endif
# if __cpp_lib_allocator_traits_is_always_equal != 201411L # if __cpp_lib_allocator_traits_is_always_equal != 201411L
# error "__cpp_lib_allocator_traits_is_always_equal should have the value 201411L in c++20" # error "__cpp_lib_allocator_traits_is_always_equal should have the value 201411L in c++20"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_constexpr_vector # ifndef __cpp_lib_constexpr_vector
# error "__cpp_lib_constexpr_vector should be defined in c++20" # error "__cpp_lib_constexpr_vector should be defined in c++20"
# endif # endif
# if __cpp_lib_constexpr_vector != 201907L # if __cpp_lib_constexpr_vector != 201907L
# error "__cpp_lib_constexpr_vector should have the value 201907L in c++20" # error "__cpp_lib_constexpr_vector should have the value 201907L in c++20"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_constexpr_vector
# error "__cpp_lib_constexpr_vector should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifndef __cpp_lib_erase_if # ifndef __cpp_lib_erase_if
# error "__cpp_lib_erase_if should be defined in c++20" # error "__cpp_lib_erase_if should be defined in c++20"
# endif # endif
# if __cpp_lib_erase_if != 202002L # if __cpp_lib_erase_if != 202002L
# error "__cpp_lib_erase_if should have the value 202002L in c++20" # error "__cpp_lib_erase_if should have the value 202002L in c++20"
# endif # endif
Show All 19 Lines
# ifndef __cpp_lib_allocator_traits_is_always_equal # ifndef __cpp_lib_allocator_traits_is_always_equal
# error "__cpp_lib_allocator_traits_is_always_equal should be defined in c++2b" # error "__cpp_lib_allocator_traits_is_always_equal should be defined in c++2b"
# endif # endif
# if __cpp_lib_allocator_traits_is_always_equal != 201411L # if __cpp_lib_allocator_traits_is_always_equal != 201411L
# error "__cpp_lib_allocator_traits_is_always_equal should have the value 201411L in c++2b" # error "__cpp_lib_allocator_traits_is_always_equal should have the value 201411L in c++2b"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_constexpr_vector # ifndef __cpp_lib_constexpr_vector
# error "__cpp_lib_constexpr_vector should be defined in c++2b" # error "__cpp_lib_constexpr_vector should be defined in c++2b"
# endif # endif
# if __cpp_lib_constexpr_vector != 201907L # if __cpp_lib_constexpr_vector != 201907L
# error "__cpp_lib_constexpr_vector should have the value 201907L in c++2b" # error "__cpp_lib_constexpr_vector should have the value 201907L in c++2b"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_constexpr_vector
# error "__cpp_lib_constexpr_vector should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifndef __cpp_lib_erase_if # ifndef __cpp_lib_erase_if
# error "__cpp_lib_erase_if should be defined in c++2b" # error "__cpp_lib_erase_if should be defined in c++2b"
# endif # endif
# if __cpp_lib_erase_if != 202002L # if __cpp_lib_erase_if != 202002L
# error "__cpp_lib_erase_if should have the value 202002L in c++2b" # error "__cpp_lib_erase_if should have the value 202002L in c++2b"
# endif # endif
Show All 29 Lines

libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp

Show First 20 Lines • Show All 2,766 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_constexpr_utility # ifndef __cpp_lib_constexpr_utility
# error "__cpp_lib_constexpr_utility should be defined in c++20" # error "__cpp_lib_constexpr_utility should be defined in c++20"
# endif # endif
# if __cpp_lib_constexpr_utility != 201811L # if __cpp_lib_constexpr_utility != 201811L
# error "__cpp_lib_constexpr_utility should have the value 201811L in c++20" # error "__cpp_lib_constexpr_utility should have the value 201811L in c++20"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_constexpr_vector # ifndef __cpp_lib_constexpr_vector
# error "__cpp_lib_constexpr_vector should be defined in c++20" # error "__cpp_lib_constexpr_vector should be defined in c++20"
# endif # endif
# if __cpp_lib_constexpr_vector != 201907L # if __cpp_lib_constexpr_vector != 201907L
# error "__cpp_lib_constexpr_vector should have the value 201907L in c++20" # error "__cpp_lib_constexpr_vector should have the value 201907L in c++20"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_constexpr_vector
# error "__cpp_lib_constexpr_vector should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifndef __cpp_lib_coroutine # ifndef __cpp_lib_coroutine
# error "__cpp_lib_coroutine should be defined in c++20" # error "__cpp_lib_coroutine should be defined in c++20"
# endif # endif
# if __cpp_lib_coroutine != 201902L # if __cpp_lib_coroutine != 201902L
# error "__cpp_lib_coroutine should have the value 201902L in c++20" # error "__cpp_lib_coroutine should have the value 201902L in c++20"
# endif # endif
▲ Show 20 Lines • Show All 1,215 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_constexpr_utility # ifndef __cpp_lib_constexpr_utility
# error "__cpp_lib_constexpr_utility should be defined in c++2b" # error "__cpp_lib_constexpr_utility should be defined in c++2b"
# endif # endif
# if __cpp_lib_constexpr_utility != 201811L # if __cpp_lib_constexpr_utility != 201811L
# error "__cpp_lib_constexpr_utility should have the value 201811L in c++2b" # error "__cpp_lib_constexpr_utility should have the value 201811L in c++2b"
# endif # endif
# if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_constexpr_vector # ifndef __cpp_lib_constexpr_vector
# error "__cpp_lib_constexpr_vector should be defined in c++2b" # error "__cpp_lib_constexpr_vector should be defined in c++2b"
# endif # endif
# if __cpp_lib_constexpr_vector != 201907L # if __cpp_lib_constexpr_vector != 201907L
# error "__cpp_lib_constexpr_vector should have the value 201907L in c++2b" # error "__cpp_lib_constexpr_vector should have the value 201907L in c++2b"
# endif # endif
# else // _LIBCPP_VERSION
# ifdef __cpp_lib_constexpr_vector
# error "__cpp_lib_constexpr_vector should not be defined because it is unimplemented in libc++!"
# endif
# endif
# ifndef __cpp_lib_coroutine # ifndef __cpp_lib_coroutine
# error "__cpp_lib_coroutine should be defined in c++2b" # error "__cpp_lib_coroutine should be defined in c++2b"
# endif # endif
# if __cpp_lib_coroutine != 201902L # if __cpp_lib_coroutine != 201902L
# error "__cpp_lib_coroutine should have the value 201902L in c++2b" # error "__cpp_lib_coroutine should have the value 201902L in c++2b"
# endif # endif
▲ Show 20 Lines • Show All 955 Lines • Show Last 20 Lines

libcxx/utils/generate_feature_test_macro_components.py

Show First 20 Lines • Show All 271 Lines • ▼ Show 20 Linesfeature_test_macros = [ add_version_header(x) for x in [
}, { }, {
"name": "__cpp_lib_constexpr_utility", "name": "__cpp_lib_constexpr_utility",
"values": { "c++20": 201811 }, "values": { "c++20": 201811 },
"headers": ["utility"], "headers": ["utility"],
}, { }, {
"name": "__cpp_lib_constexpr_vector", "name": "__cpp_lib_constexpr_vector",
"values": { "c++20": 201907 }, "values": { "c++20": 201907 },
"headers": ["vector"], "headers": ["vector"],
"unimplemented": True,
}, { }, {
"name": "__cpp_lib_coroutine", "name": "__cpp_lib_coroutine",
"values": { "c++20": 201902 }, "values": { "c++20": 201902 },
"headers": ["coroutine"], "headers": ["coroutine"],
}, { }, {
"name": "__cpp_lib_destroying_delete", "name": "__cpp_lib_destroying_delete",
"values": { "c++20": 201806 }, "values": { "c++20": 201806 },
"headers": ["new"], "headers": ["new"],
▲ Show 20 Lines • Show All 934 Lines • Show Last 20 Lines