This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Add missing CMakePushCheckState include to FindLibEdit.cmake
ClosedPublic

Authored by mgorny on Nov 7 2022, 7:48 AM.

Details

Summary

Add the missing include to fix an error when cmake_push_check_state()
is called and incidentally the CMakePushCheckState module is not loaded
by any other check running prior to FindLibEdit.cmake:

CMake Error at /var/no-tmpfs/portage/dev-util/lldb-15.0.4/work/cmake/Modules/FindLibEdit.cmake:24 (cmake_push_check_state):
  Unknown CMake command "cmake_push_check_state".
Call Stack (most recent call first):
  cmake/modules/LLDBConfig.cmake:52 (find_package)
  cmake/modules/LLDBConfig.cmake:59 (add_optional_dependency)
  CMakeLists.txt:28 (include)

Gentoo Bug: https://bugs.gentoo.org/880065

Diff Detail

Event Timeline

mgorny created this revision.Nov 7 2022, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2022, 7:48 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
mgorny requested review of this revision.Nov 7 2022, 7:48 AM
upsj accepted this revision.Nov 7 2022, 8:53 AM

LGTM! My bad, thanks for fixing this

This revision is now accepted and ready to land.Nov 7 2022, 8:53 AM
This revision was landed with ongoing or failed builds.Nov 7 2022, 9:20 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2022, 9:20 AM