This is an archive of the discontinued LLVM Phabricator instance.

Differential D137135

[libc++][Android] strong_order_long_double.verify.cpp: disable on i686
ClosedPublic

Authored by rprichard on Oct 31 2022, 4:12 PM.

Details

Reviewers
ldionne
danalbert
Group Reviewers
Restricted Project
Commits
rG9e6049527f9b: [libc++][Android] strong_order_long_double.verify.cpp: disable on i686
Summary

This target (as well as 32-bit ARM Android) have sizeof(long double)
equal to sizeof(double).

Diff Detail

Event Timeline

rprichard created this revision.Oct 31 2022, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 4:12 PM
Herald added subscribers: danielkiss, kristof.beyls. · View Herald Transcript
rprichard requested review of this revision.Oct 31 2022, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 4:12 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
rprichard added a subscriber: smeenai.Oct 31 2022, 4:12 PM
Harbormaster completed remote builds in B195388: Diff 472177.Oct 31 2022, 11:05 PM
ldionne accepted this revision.Nov 1 2022, 8:58 AM

LGTM w/ comment.

libcxx/test/std/language.support/cmp/cmp.alg/strong_order_long_double.verify.cpp
20

Please add a comment similar to what the other platforms have.

This revision is now accepted and ready to land.Nov 1 2022, 8:58 AM
rprichard updated this revision to Diff 472442.Nov 1 2022, 4:26 PM

Add a comment.

Harbormaster completed remote builds in B195578: Diff 472442.Nov 1 2022, 6:55 PM
Closed by commit rG9e6049527f9b: [libc++][Android] strong_order_long_double.verify.cpp: disable on i686 (authored by rprichard). · Explain WhyNov 2 2022, 2:56 PM
This revision was automatically updated to reflect the committed changes.
rprichard added a commit: rG9e6049527f9b: [libc++][Android] strong_order_long_double.verify.cpp: disable on i686.

Revision Contents

PathSize
libcxx/
test/
std/
language.support/
cmp/
cmp.alg/
2 lines

Diff 472780

libcxx/test/std/language.support/cmp/cmp.alg/strong_order_long_double.verify.cpp

Show All 11 Lines
// This test does apply to aarch64 where Arm's AAPCS64 is followed. There they are different sizes. // This test does apply to aarch64 where Arm's AAPCS64 is followed. There they are different sizes.
// UNSUPPORTED: target={{arm64|armv(7|8)(l|m)?|powerpc|powerpc64}}-{{.+}} // UNSUPPORTED: target={{arm64|armv(7|8)(l|m)?|powerpc|powerpc64}}-{{.+}}
// MSVC configurations have long double equal to regular double on all // MSVC configurations have long double equal to regular double on all
// architectures. // architectures.
// UNSUPPORTED: target={{.+}}-pc-windows-msvc // UNSUPPORTED: target={{.+}}-pc-windows-msvc
// ARM/AArch64 MinGW also has got long double equal to regular double, just // ARM/AArch64 MinGW also has got long double equal to regular double, just
// like MSVC (thus match both MinGW and MSVC here, for those architectures). // like MSVC (thus match both MinGW and MSVC here, for those architectures).
// UNSUPPORTED: target={{aarch64|armv7}}-{{.*}}-windows-{{.+}} // UNSUPPORTED: target={{aarch64|armv7}}-{{.*}}-windows-{{.+}}
// Android's 32-bit x86 target has long double equal to regular double.
ldionneUnsubmitted
Not Done
ReplyInline Actions

Please add a comment similar to what the other platforms have.

ldionne: Please add a comment similar to what the other platforms have.
// UNSUPPORTED: target=i686-{{.+}}-android{{.*}}
// <compare> // <compare>
// template<class T> constexpr strong_ordering strong_order(const T& a, const T& b); // template<class T> constexpr strong_ordering strong_order(const T& a, const T& b);
// libc++ does not support strong_order(long double, long double) quite yet. // libc++ does not support strong_order(long double, long double) quite yet.
// This test verifies the error message we give for that case. // This test verifies the error message we give for that case.
// TODO: remove this test once long double is properly supported. // TODO: remove this test once long double is properly supported.
Show All 9 Lines