This is an archive of the discontinued LLVM Phabricator instance.

[libc++][Android] Include cstdlib to define __BIONIC__
ClosedPublic

Authored by rprichard on Oct 31 2022, 3:47 PM.

Details

Summary

ANDROID is a built-in compiler macro, but BIONIC is defined by
the libc header.

Diff Detail

Event Timeline

rprichard created this revision.Oct 31 2022, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 3:47 PM
Herald added a subscriber: danielkiss. · View Herald Transcript
rprichard requested review of this revision.Oct 31 2022, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 3:47 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
rprichard retitled this revision from [libc++][Android] Include stdlib.h to define __BIONIC__ to [libc++][Android] Include cstdlib to define __BIONIC__.Dec 5 2022, 3:26 PM
compnerd accepted this revision.Dec 8 2022, 10:30 AM
compnerd added a subscriber: compnerd.

Seems like a straightforward change for the tests to repair them on Android.

This revision is now accepted and ready to land.Dec 8 2022, 10:30 AM
This revision was automatically updated to reflect the committed changes.