VE: Register null MCTargetStreamer

[arsenm]

ping

[arsenm]

ping

[arsenm]

ping

[kaz7]

Thanks! I'll check it out soon. sorry for multiple pings.

Outlook for iOShttps://aka.ms/o0ukef $B$rF~<j(B

---

$B:9=P?M(B: Matt Arsenault via Phabricator <[e-mail]>
$BAw?.F|;~(B: Wednesday, January 4, 2023 6:23:39 AM
$B08@h(B: MARUKAWA KAZUSHI($B4]@n!!0l;V(B) <[e-mail]>; [e-mail] <[e-mail]>
CC: [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>; [e-mail] <[e-mail]>
$B7oL>(B: [PATCH] D137122: VE: Register null MCTargetStreamer

arsenm added a comment.

ping

CHANGES SINCE LAST ACTION

https://reviews.llvm.org/D137122/new/

https://reviews.llvm.org/D137122

[jrtc27]

llvm/lib/Target/VE/MCTargetDesc/VETargetStreamer.h

23

clang-format surely wants a space before {}?

[kaz7]

LGTM

[arsenm]

5b7fa4a48d4e1dc5d412add989ce5c1b2dc7a448

llvm/lib/Target/VE/MCTargetDesc/VEMCTargetDesc.cpp

 
 static MCTargetStreamer *createTargetAsmStreamer(MCStreamer &S,
                                                  formatted_raw_ostream &OS,
                                                  MCInstPrinter *InstPrint,
                                                  bool isVerboseAsm) {
   return new VETargetAsmStreamer(S, OS);
 }
 
+static MCTargetStreamer *createNullTargetStreamer(MCStreamer &S) {
+  return new VETargetStreamer(S);
+}
+
 static MCInstPrinter *createVEMCInstPrinter(const Triple &T,
                                             unsigned SyntaxVariant,
                                             const MCAsmInfo &MAI,
                                             const MCInstrInfo &MII,
                                             const MCRegisterInfo &MRI) {
   return new VEInstPrinter(MAI, MII, MRI);
 }
 
for (Target *T : {&getTheVETarget()}) {
 
     // Register the object target streamer.
     TargetRegistry::RegisterObjectTargetStreamer(*T,
                                                  createObjectTargetStreamer);
 
     // Register the asm streamer.
     TargetRegistry::RegisterAsmTargetStreamer(*T, createTargetAsmStreamer);
 
+    // Register the null streamer.
+    TargetRegistry::RegisterNullTargetStreamer(*T, createNullTargetStreamer);
+
     // Register the MCInstPrinter
     TargetRegistry::RegisterMCInstPrinter(*T, createVEMCInstPrinter);
   }
 }

llvm/lib/Target/VE/MCTargetDesc/VETargetStreamer.h

 
 namespace llvm {
 class VETargetStreamer : public MCTargetStreamer {
   virtual void anchor();
 
 public:
   VETargetStreamer(MCStreamer &S);
   /// Emit ".register <reg>, #ignore".
-  virtual void emitVERegisterIgnore(unsigned reg) = 0;
+  virtual void emitVERegisterIgnore(unsigned reg){};
   /// Emit ".register <reg>, #scratch".
-  virtual void emitVERegisterScratch(unsigned reg) = 0;
+  virtual void emitVERegisterScratch(unsigned reg){};
 };
 
 // This part is for ascii assembly output
 class VETargetAsmStreamer : public VETargetStreamer {
   formatted_raw_ostream &OS;
 
 public:
   VETargetAsmStreamer(MCStreamer &S, formatted_raw_ostream &OS);

llvm/test/CodeGen/VE/null-mctargetstreamer.ll

+; RUN: llc -march=ve -filetype=null %s
+
+define void @foo() {
+  ret void
+}