This is an archive of the discontinued LLVM Phabricator instance.

[asan][test] Fix build errors in loongarch64
ClosedPublic

Authored by tangyouling on Oct 29 2022, 1:50 AM.

Details

Summary
  • Add get_bits_for_arch for loongarch64 detection, fix the following error,
$ make check-asan
-- sanitizer_common tests on "Linux" will run against "asan"
CMake Error at test/asan/CMakeLists.txt:22 (message):
  Unknown target architecture: loongarch64
Call Stack (most recent call first):
  test/asan/CMakeLists.txt:49 (get_bits_for_arch)
  • Do not use __builtin_longjmp, fix the following error,
llvm-project/compiler-rt/lib/asan/tests/asan_test.cpp:635:3: error: __builtin_longjmp is not supported for the current target
  __builtin_longjmp((void**)buf, 1);

Diff Detail

Event Timeline

tangyouling created this revision.Oct 29 2022, 1:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2022, 1:50 AM
tangyouling requested review of this revision.Oct 29 2022, 1:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2022, 1:50 AM
Herald added subscribers: Restricted Project, pcwang-thead. · View Herald Transcript
xry111 accepted this revision.Oct 29 2022, 1:55 AM

LGTM.

This revision is now accepted and ready to land.Oct 29 2022, 1:55 AM
MaskRay accepted this revision.EditedOct 29 2022, 11:02 AM
MaskRay added a reviewer: Restricted Project.

[LoongArch][ASAN] Fix build errors in loongarch64 when testing asan

[ASAN] is uncommon. [asan] is. [test] is appropriate if this only touches tests. Personally I'd drop [LoongArch].

Add maintainers to the review list, not just a few who have previously reviewed LoongArch related patches.

tangyouling retitled this revision from [LoongArch][ASAN] Fix build errors in loongarch64 when testing asan to [asan][test] Fix build errors in loongarch64 when testing asan.Oct 30 2022, 6:08 PM

[LoongArch][ASAN] Fix build errors in loongarch64 when testing asan

[ASAN] is uncommon. [asan] is. [test] is appropriate if this only touches tests. Personally I'd drop [LoongArch].

OK, revised.

Add maintainers to the review list, not just a few who have previously reviewed LoongArch related patches.

Thank you for the reminder.

tangyouling retitled this revision from [asan][test] Fix build errors in loongarch64 when testing asan to [asan][test] Fix build errors in loongarch64.Oct 30 2022, 6:14 PM
This revision was landed with ongoing or failed builds.Nov 1 2022, 5:23 AM
This revision was automatically updated to reflect the committed changes.