This is an archive of the discontinued LLVM Phabricator instance.

Differential D136674

[LLDB] Fix RISCV build
ClosedPublic

Authored by Emmmer on Oct 25 2022, 4:23 AM.

Details

Reviewers
DavidSpickett
Commits
rGc094b1eef08c: [LLDB] Fix RISCV build
Summary

After https://reviews.llvm.org/D135670

Diff Detail

Event Timeline

Emmmer created this revision.Oct 25 2022, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2022, 4:23 AM
Herald added subscribers: sunshaoce, VincentWu, vkmr and 27 others. · View Herald Transcript
Emmmer requested review of this revision.Oct 25 2022, 4:23 AM
Herald added subscribers: • pcwang-thead, eopXD. · View Herald TranscriptOct 25 2022, 4:23 AM
Harbormaster completed remote builds in B194143: Diff 470442.Oct 25 2022, 4:26 AM
DavidSpickett accepted this revision.Oct 25 2022, 5:10 AM

Thanks! Apologies (I missed a few x86 ones at the time too).

This revision is now accepted and ready to land.Oct 25 2022, 5:10 AM
Closed by commit rGc094b1eef08c: [LLDB] Fix RISCV build (authored by Emmmer). · Explain WhyOct 25 2022, 8:03 AM
This revision was automatically updated to reflect the committed changes.
Emmmer added a commit: rGc094b1eef08c: [LLDB] Fix RISCV build.
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2022, 8:03 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript

Revision Contents

PathSize
lldb/
source/
Plugins/
Process/
Linux/
2 lines

Diff 470502

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.cpp

Show First 20 Lines • Show All 129 Lines • ▼ Show 20 Lines if (IsGPR(reg)) {
offset = CalculateFprOffset(reg_info); offset = CalculateFprOffset(reg_info);
assert(offset < GetFPRSize()); assert(offset < GetFPRSize());
src = (uint8_t *)GetFPRBuffer() + offset; src = (uint8_t *)GetFPRBuffer() + offset;
} else } else
return Status("failed - register wasn't recognized to be a GPR or an FPR, " return Status("failed - register wasn't recognized to be a GPR or an FPR, "
"write strategy unknown"); "write strategy unknown");
reg_value.SetFromMemoryData(reg_info, src, reg_info->byte_size, reg_value.SetFromMemoryData(*reg_info, src, reg_info->byte_size,
eByteOrderLittle, error); eByteOrderLittle, error);
return error; return error;
} }
Status NativeRegisterContextLinux_riscv64::WriteRegister( Status NativeRegisterContextLinux_riscv64::WriteRegister(
const RegisterInfo *reg_info, const RegisterValue &reg_value) { const RegisterInfo *reg_info, const RegisterValue &reg_value) {
Status error; Status error;
▲ Show 20 Lines • Show All 203 Lines • Show Last 20 Lines