This is an archive of the discontinued LLVM Phabricator instance.

[lit][REQUIRES] Fix REQUIRES on an NVPTX test so it will run
ClosedPublic

Authored by probinson on Oct 24 2022, 9:52 AM.

Details

Summary

Had to fix attributes as well, not sure which ones it should actually care about.

Diff Detail

Event Timeline

probinson created this revision.Oct 24 2022, 9:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 9:52 AM
probinson requested review of this revision.Oct 24 2022, 9:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 9:52 AM
tra accepted this revision.Oct 24 2022, 10:03 AM
tra added a subscriber: tra.

Do we have any other convergent intrinsics in back-ends more common than NVPTX? If we have one in X86 or ARM that would be a better choice for this test than @llvm.nvvm.barrier0.

This revision is now accepted and ready to land.Oct 24 2022, 10:03 AM

Thanks!

Do we have any other convergent intrinsics in back-ends more common than NVPTX?

Beats me. I'm just fixing tests that have undefined keywords in the various lit directives.
Naively I'd think we want tests to verify that all intrinsics have the appropriate attributes, but I'm not in a position to say what those are or where they should live.

This revision was landed with ongoing or failed builds.Oct 24 2022, 10:13 AM
This revision was automatically updated to reflect the committed changes.