This is an archive of the discontinued LLVM Phabricator instance.

Differential D136546

[clang][unittest] Resolve ClangSupportTest link time errors
ClosedPublic

Authored by jmciver on Oct 22 2022, 10:04 PM.

Details

Reviewers
Izaron
Ericson2314
thieta
tstellar
Commits
rGe5032d89e44a: [clang][unittest] Resolve ClangSupportTest link time errors
Summary

Resolves undefined references to vtable for clang::ASTConsumer,
PCHContainerOperations::PCHContainerOperations(), and
CodeGenOptions::CodeGenOptions().

Diff Detail

Event Timeline

jmciver created this revision.Oct 22 2022, 10:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2022, 10:04 PM
jmciver added reviewers: Izaron, Ericson2314, thieta, tstellar.Oct 22 2022, 10:15 PM
jmciver published this revision for review.Oct 22 2022, 10:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2022, 10:19 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B193790: Diff 469961.Oct 22 2022, 10:37 PM
jmciver added a comment.Oct 22 2022, 10:46 PM

Added GitHub issue 58553, which provides the full error message and repeatability information.

If this patch is accepted can someone please commit on my behalf?

  • User name: John McIver
  • User email: john.mciver.iii@gmail.com
Izaron added a comment.Oct 23 2022, 2:51 AM

LGTM! I'm sorry that you had to fix CMakeLists.txt. It really "worked on my machine", I was running these commands:

cmake --build build --target ClangSupportTests # build and link the binary
./build/tools/clang/unittests/Support/ClangSupportTests # run the binary
Izaron accepted this revision.Oct 23 2022, 2:51 AM
This revision is now accepted and ready to land.Oct 23 2022, 2:51 AM
Closed by commit rGe5032d89e44a: [clang][unittest] Resolve ClangSupportTest link time errors (authored by jmciver, committed by Izaron). · Explain WhyOct 23 2022, 2:55 AM
This revision was automatically updated to reflect the committed changes.
Izaron added a commit: rGe5032d89e44a: [clang][unittest] Resolve ClangSupportTest link time errors.
jmciver added a comment.Oct 23 2022, 8:40 AM

Thanks @Izaron for taking the time to review and commit on my behalf!

Revision Contents

PathSize
clang/
unittests/
Support/
3 lines

Diff 469970

clang/unittests/Support/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_clang_unittest(ClangSupportTests add_clang_unittest(ClangSupportTests
TimeProfilerTest.cpp TimeProfilerTest.cpp
) )
clang_target_link_libraries(ClangSupportTests clang_target_link_libraries(ClangSupportTests
PRIVATE PRIVATE
clangAST
clangBasic
clangFrontend clangFrontend
clangSerialization
) )