This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Fixed CMakeLists.txt to correctly install MLIRSparseTensorEnums
ClosedPublic

Authored by vmurali on Oct 21 2022, 11:27 AM.

Diff Detail

Event Timeline

vmurali created this revision.Oct 21 2022, 11:27 AM
Herald added a project: Restricted Project. · View Herald Transcript
vmurali requested review of this revision.Oct 21 2022, 11:27 AM
wrengr requested changes to this revision.Oct 21 2022, 1:40 PM

I talked with @vmurali offline and the problems they're encountering are specific to the IREE setup, and don't affect the LLVM/MLIR monorepo. We're currently trying to figure out how to fix things for IREE, but reverting D136217 would cause a lot of issues for a lot of other users (since it breaks the monorepo itself)

This revision now requires changes to proceed.Oct 21 2022, 1:40 PM
vmurali added a comment.EditedOct 21 2022, 1:45 PM

Understood. Let this differential be a place holder till a real solution can be found after which we can update the differential, and then commit.

vmurali updated this revision to Diff 469763.Oct 21 2022, 2:12 PM
vmurali retitled this revision from Reverting commit 5e12c183920b506f83b2a10205b4a26b17ca9115. to Fixed CMakeLists.txt to export mlir/include/mlir/Dialenct/SparseTensor/IR/Enums.h correctly for installing MLIRSparseTensorEnums as a library in other projects using MLIR.
vmurali edited the summary of this revision. (Show Details)
wrengr accepted this revision.Oct 21 2022, 2:19 PM

Assuming this passes the buildbot, then lgtm. I have some nits but I can handle those in a followup differential.

This revision is now accepted and ready to land.Oct 21 2022, 2:19 PM
wrengr retitled this revision from Fixed CMakeLists.txt to export mlir/include/mlir/Dialenct/SparseTensor/IR/Enums.h correctly for installing MLIRSparseTensorEnums as a library in other projects using MLIR to [mlir][sparse] Fixed CMakeLists.txt to correctly install MLIRSparseTensorEnums.Oct 21 2022, 2:21 PM
This revision was landed with ongoing or failed builds.Oct 21 2022, 2:48 PM
This revision was automatically updated to reflect the committed changes.