This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GISel] Re-enable some working tests
ClosedPublic

Authored by Pierre-vh on Oct 20 2022, 5:28 AM.

Details

Summary

These tests had been commented out but seem to not be crashing.
Not sure if codegen is perfect in each of them, but even if it's not I think it's better to put a TODO to fix codegen than remove the test outright, unless codegen is plain wrong (then I'd still rather XFAIL rather than hide it)

Diff Detail

Event Timeline

Pierre-vh created this revision.Oct 20 2022, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 5:28 AM
Pierre-vh requested review of this revision.Oct 20 2022, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 5:28 AM
arsenm accepted this revision.Oct 20 2022, 7:47 AM

LGTM. I think there were assertions in 3 vector calling convention lowering

This revision is now accepted and ready to land.Oct 20 2022, 7:47 AM
This revision was automatically updated to reflect the committed changes.