This is an archive of the discontinued LLVM Phabricator instance.

[libc++][PMR] Deprecate the implementation in std::experimental
ClosedPublic

Authored by philnik on Oct 19 2022, 4:17 AM.

Details

Summary

This commit deprecates <experimental/memory_resource> since we now ship the non-experimental
version of it. Per the libc++ policy [1], we are deprecating the experimental feature in
upcoming LLVM 16 and will remove it entirely in LLVM 18.

[1]: https://libcxx.llvm.org/DesignDocs/ExperimentalFeatures.html#id4

Diff Detail

Event Timeline

philnik created this revision.Oct 19 2022, 4:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 4:17 AM
philnik requested review of this revision.Oct 19 2022, 4:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 4:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Thanks for patch! Please update the release notes with this deprecation.

ldionne accepted this revision.Oct 20 2022, 8:53 AM

LGTM but I agree we need to add a release note.

This revision is now accepted and ready to land.Oct 20 2022, 8:53 AM
philnik updated this revision to Diff 471780.Oct 29 2022, 1:16 PM
  • Rebased
  • Added release note
EricWF requested changes to this revision.Oct 30 2022, 10:04 AM
EricWF added a subscriber: EricWF.

Needs description.

Do not commit without one.

The description should include *why* these were deprecated, (so mention the policy, or the bit of the standard that deprecates them.)

This revision now requires changes to proceed.Oct 30 2022, 10:04 AM
philnik edited the summary of this revision. (Show Details)Oct 31 2022, 8:32 AM
ldionne accepted this revision.Oct 31 2022, 10:32 AM

LGTM w/ a suggested rewording of the release note. Thanks for adding a link to the policy in the commit message. Also, the commit message could be reworded to

This commit deprecates <experimental/memory_resource> since we now ship the non-experimental
version of it. Per the libc++ policy [1], we are deprecating the experimental feature in
upcoming LLVM 16 and will remove it entirely in LLVM 18.

[1]: https://libcxx.llvm.org/DesignDocs/ExperimentalFeatures.html#id4

This should minimize the amount of work that someone has to do in order to understand what's the change and the context around it.

libcxx/docs/ReleaseNotes.rst
95–96 ↗(On Diff #472025)
philnik edited the summary of this revision. (Show Details)Oct 31 2022, 4:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 31 2022, 4:37 PM
This revision was automatically updated to reflect the committed changes.
philnik marked an inline comment as done.