This is an archive of the discontinued LLVM Phabricator instance.

[docs] Add the description about mixing use of clang modules and c++ modules
ClosedPublic

Authored by ChuanqiXu on Oct 18 2022, 7:56 PM.

Details

Summary

From the discussion in https://discourse.llvm.org/t/how-should-we-support-dependency-scanner-for-c-20-modules/66027, we get a consensus that we want to support clang modules and c++ modules at the same time. This patch documents this intention.

Diff Detail

Event Timeline

ChuanqiXu created this revision.Oct 18 2022, 7:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 7:56 PM
ChuanqiXu requested review of this revision.Oct 18 2022, 7:56 PM

I want to land this two weeks later if no objection shows.

bruno accepted this revision as: bruno.Oct 21 2022, 12:08 PM
bruno added a subscriber: bruno.

Looks great, some minor suggestions.

clang/docs/StandardCPlusPlusModules.rst
877

I would rewrite the section name as "Interoperability with Clang Modules"

881

"... same time, but the mixed ..."

882

How about: "Please file new github issues as you find interoperability problems"

This revision is now accepted and ready to land.Oct 21 2022, 12:08 PM
vsapsai added inline comments.
clang/docs/StandardCPlusPlusModules.rst
880

@Bigcheese Is it worth adding something like "A big user of such mode is Objective-C++ code"?

ChuanqiXu updated this revision to Diff 470036.Oct 23 2022, 8:01 PM

Address comments.

ChuanqiXu marked 3 inline comments as done.Oct 23 2022, 8:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 1:03 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript