This is an archive of the discontinued LLVM Phabricator instance.

[libc++][PMR] Add attributes
ClosedPublic

Authored by philnik on Oct 18 2022, 11:40 AM.

Details

Reviewers
ldionne
Mordante
var-const
Group Reviewers
Restricted Project
Commits
rGf4ca5da2be3f: [libc++][PMR] Add attributes
Summary

This allows the compiler to do more optimizations.

Diff Detail

Event Timeline

philnik created this revision.Oct 18 2022, 11:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 11:40 AM
Herald added a subscriber: krytarowski. · View Herald Transcript
philnik requested review of this revision.Oct 18 2022, 11:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 11:40 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 468830.Oct 19 2022, 2:48 AM

Try to fix CI

philnik updated this revision to Diff 468864.Oct 19 2022, 4:04 AM

Try to fix CI

ldionne accepted this revision.Oct 20 2022, 8:47 AM

We went over these attributes just now and I believe they are correctly applied. We also discussed how to test this, but since it's not observable in most cases (except those that produce a diagnostic), I think this is acceptable as-is.

This revision is now accepted and ready to land.Oct 20 2022, 8:47 AM
philnik updated this revision to Diff 471775.Oct 29 2022, 12:56 PM

Rebased; Fix CI

This revision was automatically updated to reflect the committed changes.