This is an archive of the discontinued LLVM Phabricator instance.

[flang] Restrict __float128 support for some build configurations.

Authored by vzakhari on Oct 17 2022, 5:54 PM.



This change is intended to resolve build issues reported in D134503.
A compiler supporting float128 must define either FLOAT128__ or
SIZEOF_FLOAT128 (or both). Additional check for _LIBCPP_VERSION
was added to disable float128 for builds with libc++, because
float128 support is incomplete there.

Diff Detail

Event Timeline

vzakhari created this revision.Oct 17 2022, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 5:54 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
vzakhari requested review of this revision.Oct 17 2022, 5:54 PM
jeanPerier accepted this revision.Oct 18 2022, 1:54 AM

Thanks a lot for figuring this out Slava. This works for me and LGTM.

This revision is now accepted and ready to land.Oct 18 2022, 1:54 AM

This works for me as well and fixes the error I was seeing--thank you for looking into this and submitting this!