This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Handle unions like structs and classes
ClosedPublic

Authored by HazardyKnusperkeks on Oct 13 2022, 5:41 AM.

Reviewers

Commits

Summary

There is no reason why unions should be handled differently, I think they are just forgotten since they are not used that often.

No test case added, since that would be complicated to produce.

LGTM

This revision is now accepted and ready to land.Oct 13 2022, 3:53 PM

This revision was landed with ongoing or failed builds.Oct 24 2022, 12:28 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang/

lib/

Format/

2 lines

Show First 20 Lines • Show All 3,151 Lines • ▼ Show 20 Lines	unsigned TokenAnnotator::splitPenalty(const AnnotatedLine &Line,
if (Right.is(TT_PointerOrReference))		if (Right.is(TT_PointerOrReference))
return 190;		return 190;
if (Right.is(TT_LambdaArrow))		if (Right.is(TT_LambdaArrow))
return 110;		return 110;
if (Left.is(tok::equal) && Right.is(tok::l_brace))		if (Left.is(tok::equal) && Right.is(tok::l_brace))
return 160;		return 160;
if (Left.is(TT_CastRParen))		if (Left.is(TT_CastRParen))
return 100;		return 100;
if (Left.isOneOf(tok::kw_class, tok::kw_struct))		if (Left.isOneOf(tok::kw_class, tok::kw_struct, tok::kw_union))
return 5000;		return 5000;
if (Left.is(tok::comment))		if (Left.is(tok::comment))
return 1000;		return 1000;

if (Left.isOneOf(TT_RangeBasedForLoopColon, TT_InheritanceColon,		if (Left.isOneOf(TT_RangeBasedForLoopColon, TT_InheritanceColon,
TT_CtorInitializerColon)) {		TT_CtorInitializerColon)) {
return 2;		return 2;
}		}
▲ Show 20 Lines • Show All 1,956 Lines • Show Last 20 Lines