[flang] Use the ShapedType::kDynamicSize constant instead of hardcoding it.

[kiranchandramohan]

Thanks for preparing this patch. I think adding the mlir:: namespace fixes the compilation issue.

flang/include/flang/Optimizer/Dialect/FIRTypes.td

494–497

[pifon2a]

add mlir::

[pifon2a]

Thank you, @kiranchandramohan . Please, take another look.

[kiranchandramohan]

Thanks once again.

As @clementval mentioned, this could have been part of the original patch as well. I think patches to MLIR also go through a precommit CI (triggered by phabricator) so you get to know whether the patch works as expected for Flang. You can also check flang by using the following commands after cloning llvm-project and creating and switching to a build directory.

cmake -G Ninja ../llvm -DLLVM_ENABLE_PROJECTS="mlir;flang;clang" -DLLVM_TARGETS_TO_BUILD=host -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON
ninja check-flang

flang/include/flang/Optimizer/Dialect/FIRTypes.td

bool hasDynamicExtents() const {
         if (d == getUnknownExtent())
           return true;
       return false;
     }
 
     // Does the sequence have unknown shape? (`array<* x T>`)
     bool hasUnknownShape() const { return getShape().empty(); }
 
-    // The value `-1` represents an unknown extent for a dimension
-    static constexpr Extent getUnknownExtent() { return -1; }
+    // The value `kDynamicSize` represents an unknown extent for a dimension
+    static constexpr Extent getUnknownExtent() {
+      return mlir::ShapedType::kDynamicSize;
+    }
   }];
 }
 
 def fir_SliceType : FIR_Type<"Slice", "slice"> {
   let summary = "FIR slice";
 
   let description = [{
     Type of a vector that represents an array slice operation on an array.