This is an archive of the discontinued LLVM Phabricator instance.

Differential D135475

[BOLT][TEST] Fix section order test
ClosedPublic

Authored by maksfb on Oct 7 2022, 11:59 AM.

Details

Reviewers
yota9
Amir
ayermolo
rafauler
Commits
rG978f11c8e8da: [BOLT][TEST] Fix section order test
Summary

.bss section emitted by llvm-bolt (e.g. with instrumentation) is not a
real BSS section, i.e. it takes space in the output file. Hence the
order with respect to .data is not defined. Remove .bss from the test
and fix the buildbot failure.

Diff Detail

Event Timeline

maksfb created this revision.Oct 7 2022, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 11:59 AM
Herald added a subscriber: treapster. · View Herald Transcript
maksfb requested review of this revision.Oct 7 2022, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 11:59 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B190988: Diff 466143.Oct 7 2022, 12:13 PM
Amir accepted this revision.Oct 7 2022, 12:58 PM
This revision is now accepted and ready to land.Oct 7 2022, 12:58 PM
Closed by commit rG978f11c8e8da: [BOLT][TEST] Fix section order test (authored by maksfb). · Explain WhyOct 7 2022, 2:39 PM
This revision was automatically updated to reflect the committed changes.
maksfb added a commit: rG978f11c8e8da: [BOLT][TEST] Fix section order test.

Revision Contents

PathSize
bolt/
test/
runtime/
X86/
2 lines

Diff 466185

bolt/test/runtime/X86/section-order.test

REQUIRES: system-linux REQUIRES: system-linux
RUN: %clang %p/Inputs/basic-instrumentation.s -Wl,-q -o %t.exe RUN: %clang %p/Inputs/basic-instrumentation.s -Wl,-q -o %t.exe
RUN: llvm-bolt %t.exe -o %t --instrument RUN: llvm-bolt %t.exe -o %t --instrument
RUN: llvm-readelf --section-headers %t | FileCheck %s RUN: llvm-readelf --section-headers %t | FileCheck %s
## Verify that llvm-bolt outputs new sections in expected order. ## Verify that llvm-bolt outputs new sections in expected order.
CHECK: .text.bolt.extra.1 CHECK: .text.bolt.extra.1
CHECK: .rodata.bolt.extra.1 CHECK: .rodata.bolt.extra.1
CHECK: .data.bolt.extra.1 CHECK: .data.bolt.extra.1
CHECK: .bss.bolt.extra.1