[Flang] Use the ultimate symbol in a DeallocateStmt check

[kiranchandramohan]

Summary

Use the ultimate symbol while calling the IsAllocatableOrPointer
function to ensure that the check works as expected for
host-associated symbols.

Fixes #58178

[PeteSteinfeld]

Please run clang-format on check-deallocate.cpp before submitting.

Other than that, all builds and tests correctly and looks good.

Thanks for fixing this!

flang/lib/Semantics/check-deallocate.cpp

29–30

I get a diff on this line when I run clang-format.

[kiranchandramohan]

clang-format check-deallocate.cpp

flang/lib/Semantics/check-deallocate.cpp

common::visit(
         common::visitors{
             [&](const parser::Name &name) {
               auto const *symbol{name.symbol};
               if (context_.HasError(symbol)) {
                 // already reported an error
               } else if (!IsVariableName(*symbol)) {
                 context_.Say(name.source,
                     "name in DEALLOCATE statement must be a variable name"_err_en_US);
-              } else if (!IsAllocatableOrPointer(*symbol)) { // C932
+              } else if (!IsAllocatableOrPointer(
+                             symbol->GetUltimate())) { // C932
                 context_.Say(name.source,
                     "name in DEALLOCATE statement must have the ALLOCATABLE or POINTER attribute"_err_en_US);
               } else {
                 context_.CheckIndexVarRedefine(name);
               }
             },
             [&](const parser::StructureComponent &structureComponent) {
               // Only perform structureComponent checks it was successfully

flang/test/Semantics/OpenMP/dealloc.f90

+! RUN: %python %S/../test_errors.py %s %flang_fc1 -fopenmp
+
+! Test to check that no errors are present when allocate statements
+! are applied on privatised variables.
+
+subroutine s
+  implicit none
+  double precision,allocatable,dimension(:) :: r
+  !$omp parallel private(r)
+  allocate(r(1))
+  deallocate(r)
+  !$omp end parallel
+end subroutine