[clang][Interp] Implement bitwise Or operations

[shafik]

LGTM

[aaron.ballman]

LGTM

clang/lib/AST/Interp/ByteCodeExprGen.cpp

case BO_Div:
       return Discard(this->emitDiv(*T, BO));
     case BO_Assign:
       if (!this->emitStore(*T, BO))
         return false;
       return DiscardResult ? this->emitPopPtr(BO) : true;
     case BO_And:
       return Discard(this->emitBitAnd(*T, BO));
     case BO_Or:
+      return Discard(this->emitBitOr(*T, BO));
     case BO_LAnd:
     case BO_LOr:
     default:
       return this->bail(BO);
     }
   }
 
   return this->bail(BO);

clang/lib/AST/Interp/Integral.h

static bool div(Integral A, Integral B, unsigned OpBits, Integral *R) {
     return false;
   }
 
   static bool bitAnd(Integral A, Integral B, unsigned OpBits, Integral *R) {
     *R = Integral(A.V & B.V);
     return false;
   }
 
+  static bool bitOr(Integral A, Integral B, unsigned OpBits, Integral *R) {
+    *R = Integral(A.V | B.V);
+    return false;
+  }
+
   static bool neg(Integral A, Integral *R) {
     *R = -A;
     return false;
   }
 
   static bool comp(Integral A, Integral *R) {
     *R = Integral(~A.V);
     return false;

clang/lib/AST/Interp/Interp.h

if (!T::bitAnd(LHS, RHS, Bits, &Result)) {
     S.Stk.push<T>(Result);
     return true;
   }
   return false;
 }
 
 /// 1) Pops the RHS from the stack.
 /// 2) Pops the LHS from the stack.
+/// 3) Pushes 'LHS | RHS' on the stack
+template <PrimType Name, class T = typename PrimConv<Name>::T>
+bool BitOr(InterpState &S, CodePtr OpPC) {
+  const T &RHS = S.Stk.pop<T>();
+  const T &LHS = S.Stk.pop<T>();
+
+  unsigned Bits = RHS.bitWidth();
+  T Result;
+  if (!T::bitOr(LHS, RHS, Bits, &Result)) {
+    S.Stk.push<T>(Result);
+    return true;
+  }
+  return false;
+}
+
+/// 1) Pops the RHS from the stack.
+/// 2) Pops the LHS from the stack.
 /// 3) Pushes 'LHS % RHS' on the stack (the remainder of dividing LHS by RHS).
 template <PrimType Name, class T = typename PrimConv<Name>::T>
 bool Rem(InterpState &S, CodePtr OpPC) {
   const T &RHS = S.Stk.pop<T>();
   const T &LHS = S.Stk.pop<T>();
 
   if (RHS.isZero()) {
     const SourceInfo &Loc = S.Current->getSource(OpPC);

clang/lib/AST/Interp/Opcodes.td

 def Sub : AluOpcode;
 def Add : AluOpcode;
 def Mul : AluOpcode;
 def Rem : Opcode {
   let Types = [NumberTypeClass];
   let HasGroup = 1;
 }
 def BitAnd : IntegerOpcode;
+def BitOr : IntegerOpcode;
 def Div : Opcode {
   let Types = [NumberTypeClass];
   let HasGroup = 1;
 }
 
 //===----------------------------------------------------------------------===//
 // Unary operators.
 //===----------------------------------------------------------------------===//

clang/test/AST/Interp/literals.cpp

 
 namespace band {
   static_assert((10 & 1) == 0, "");
   static_assert((10 & 10) == 10, "");
 
   static_assert((1337 & -1) == 1337, "");
   static_assert((0 & gimme(12)) == 0, "");
 };
+
+namespace bitOr {
+  static_assert((10 | 1) == 11, "");
+  static_assert((10 | 10) == 10, "");
+
+  static_assert((1337 | -1) == -1, "");
+  static_assert((0 | gimme(12)) == 12, "");
+  static_assert((12 | true) == 13, "");
+};