This is an archive of the discontinued LLVM Phabricator instance.

Differential D135315

[llvm] Clear the ForwardRefDSOLocalEquivalentIDs map
ClosedPublic

Authored by leonardchan on Oct 5 2022, 1:28 PM.

Details

Reviewers
phosek
MaskRay
Commits
rG69695817f5b5: [llvm] Clear the ForwardRefDSOLocalEquivalentIDs map
Summary

I accidentally cleared ForwardRefDSOLocalEquivalentNames twice instead.

Diff Detail

Event Timeline

leonardchan created this revision.Oct 5 2022, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 1:28 PM
Herald added subscribers: StephenFan, hiraditya. · View Herald Transcript
leonardchan requested review of this revision.Oct 5 2022, 1:28 PM
Harbormaster completed remote builds in B190581: Diff 465530.Oct 5 2022, 3:16 PM
MaskRay accepted this revision.Oct 5 2022, 4:18 PM
This revision is now accepted and ready to land.Oct 5 2022, 4:18 PM
phosek accepted this revision.Oct 5 2022, 11:40 PM

LGTM

Closed by commit rG69695817f5b5: [llvm] Clear the ForwardRefDSOLocalEquivalentIDs map (authored by leonardchan). · Explain WhyOct 6 2022, 4:14 PM
This revision was automatically updated to reflect the committed changes.
leonardchan added a commit: rG69695817f5b5: [llvm] Clear the ForwardRefDSOLocalEquivalentIDs map.

Revision Contents

PathSize
llvm/
lib/
AsmParser/
2 lines

Diff 465530

llvm/lib/AsmParser/LLParser.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 244 Lines • ▼ Show 20 Linesbool LLParser::validateEndOfModule(bool UpgradeDebugInfo) {
for (auto &Iter : ForwardRefDSOLocalEquivalentIDs) { for (auto &Iter : ForwardRefDSOLocalEquivalentIDs) {
if (ResolveForwardRefDSOLocalEquivalents(Iter.first, Iter.second)) if (ResolveForwardRefDSOLocalEquivalents(Iter.first, Iter.second))
return true; return true;
} }
for (auto &Iter : ForwardRefDSOLocalEquivalentNames) { for (auto &Iter : ForwardRefDSOLocalEquivalentNames) {
if (ResolveForwardRefDSOLocalEquivalents(Iter.first, Iter.second)) if (ResolveForwardRefDSOLocalEquivalents(Iter.first, Iter.second))
return true; return true;
} }
ForwardRefDSOLocalEquivalentNames.clear(); ForwardRefDSOLocalEquivalentIDs.clear();
ForwardRefDSOLocalEquivalentNames.clear(); ForwardRefDSOLocalEquivalentNames.clear();
for (const auto &NT : NumberedTypes) for (const auto &NT : NumberedTypes)
if (NT.second.second.isValid()) if (NT.second.second.isValid())
return error(NT.second.second, return error(NT.second.second,
"use of undefined type '%" + Twine(NT.first) + "'"); "use of undefined type '%" + Twine(NT.first) + "'");
for (StringMap<std::pair<Type*, LocTy> >::iterator I = for (StringMap<std::pair<Type*, LocTy> >::iterator I =
▲ Show 20 Lines • Show All 9,285 Lines • Show Last 20 Lines