This is an archive of the discontinued LLVM Phabricator instance.

[modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.
ClosedPublic

Authored by vsapsai on Oct 4 2022, 5:56 PM.

Details

Summary

Make flags -fmodules-validate-system-headers and
-fmodules-validate-once-per-build-session orthogonal, so they have
their own independent responsibilities - if system headers should be
validated and how often.

rdar://87988889

Diff Detail

Event Timeline

vsapsai created this revision.Oct 4 2022, 5:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 5:56 PM
vsapsai requested review of this revision.Oct 4 2022, 5:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 5:56 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

This makes sense. We shouldn't re-validate system headers when -fmodules-validate-once-per-build-session is passed too.

This revision is now accepted and ready to land.Oct 11 2022, 11:04 AM