Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/SparseTensor/Transforms/SparseBufferRewriting.cpp | ||
---|---|---|
573–575 | Would it be better to wrap the function name generation into util functions (same for other function created above), it should make it easier to adjust the name later? or you can define a set of marcos for the string constant. |
Comment Actions
Replace literal filenames with constants.
mlir/lib/Dialect/SparseTensor/Transforms/SparseBufferRewriting.cpp | ||
---|---|---|
573–575 | Replace this with string constants. |
Comment Actions
Nice and concise? Any performance data already on the two versions?
mlir/lib/Dialect/SparseTensor/Transforms/SparseBufferRewriting.cpp | ||
---|---|---|
576 | Shall we name this createUnstableSortFunc for symmetry with the other one, or does that sound too ominous? ;-) | |
mlir/test/Dialect/SparseTensor/buffer_rewriting.mlir | ||
159 | supporting functions (plural?) | |
169 | extra newline? |
Would it be better to wrap the function name generation into util functions (same for other function created above), it should make it easier to adjust the name later? or you can define a set of marcos for the string constant.