This is an archive of the discontinued LLVM Phabricator instance.

[test][InstCombine] Update some test cases to use opaque pointers
ClosedPublic

Authored by bjope on Oct 3 2022, 12:11 PM.

Diff Detail

Event Timeline

bjope created this revision.Oct 3 2022, 12:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2022, 12:11 PM
bjope requested review of this revision.Oct 3 2022, 12:11 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: sstefan1. · View Herald Transcript
bjope added a reviewer: nikic.Oct 3 2022, 12:22 PM

Any reasons not to do this? (considering that it hasn't been done already)

I made a separate patch with test cases that also required update of test checks (manually or via update_test_checks.py) here: D135095
That still does not cover all InstCombine tests. I guess I wanted some feedback before spending more time on converting tests.

nikic accepted this revision.Oct 3 2022, 12:24 PM

LGTM

Any reasons not to do this? (considering that it hasn't been done already)

Nope, I just haven't gotten around to doing more test conversions. Thanks for doing this!

This revision is now accepted and ready to land.Oct 3 2022, 12:24 PM
This revision was landed with ongoing or failed builds.Oct 3 2022, 1:18 PM
This revision was automatically updated to reflect the committed changes.