This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Change pointer to ref in EmulateInstruction::ReadRegister methods
ClosedPublic

Authored by DavidSpickett on Sep 30 2022, 7:06 AM.

Details

Summary

ReadRegister and ReadRegisterAsUnsigned are always passed valid pointers,
so the parameter should be a ref to make the intent clear.

Diff Detail

Event Timeline

DavidSpickett created this revision.Sep 30 2022, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2022, 7:06 AM
DavidSpickett requested review of this revision.Sep 30 2022, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2022, 7:06 AM
clayborg accepted this revision.Oct 10 2022, 4:49 PM

sorry for the delay, was on vacation for the past week

This revision is now accepted and ready to land.Oct 10 2022, 4:49 PM

No problem, thanks for the reviews!