[lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS

[serge-sans-paille]

Summary

C++11 made the use of these macro obsolete, see https://sourceware.org/bugzilla/show_bug.cgi?id=15366

As a side effect this prevents https://github.com/swig/swig/issues/2193.

[labath]

Looking at https://bugzilla.redhat.com/show_bug.cgi?id=2128646, I'd say that the real bug is that we're defining this macro in two places. How about we leave these definitions as they are, and remove the one at bindings/interfaces.swig:5 ?

[serge-sans-paille]

In D134877#3823855, @labath wrote:

Looking at https://bugzilla.redhat.com/show_bug.cgi?id=2128646, I'd say that the real bug is that we're defining this macro in two places. How about we leave these definitions as they are, and remove the one at bindings/interfaces.swig:5 ?

In that case I would advocate for keeping the definition in the header, as it's commented (which means adding a definition for __STDC_CONSTANT_MACROS in the interface too).

[labath]

sure, sounds good. TBH, I am not sure if either of those is really needed.

[serge-sans-paille]

It turns out that the culprint macro are actually obsolete in C++11, so just get rid of them.

[labath]

ship it.

lldb/bindings/CMakeLists.txt

else()
   set(DARWIN_EXTRAS "")
 endif()
 
 set(SWIG_COMMON_FLAGS
   -c++
   -features autodoc
   -I${LLDB_SOURCE_DIR}/include
   -I${CMAKE_CURRENT_SOURCE_DIR}
-  -D__STDC_LIMIT_MACROS
-  -D__STDC_CONSTANT_MACROS
   ${DARWIN_EXTRAS}
 )
 
 function(create_relative_symlink swig_target dest_file output_dir output_name)
   get_filename_component(dest_file ${dest_file} ABSOLUTE)
   get_filename_component(output_dir ${output_dir} ABSOLUTE)
   file(RELATIVE_PATH rel_dest_file ${output_dir} ${dest_file})
   if(CMAKE_HOST_UNIX)

lldb/bindings/interfaces.swig

 /* Various liblldb typedefs that SWIG needs to know about.  */
 #define __extension__ /* Undefine GCC keyword to make Swig happy when processing glibc's stdint.h. */
-/* The ISO C99 standard specifies that in C++ implementations limit macros such
-   as INT32_MAX should only be defined if __STDC_LIMIT_MACROS is. */
-#define __STDC_LIMIT_MACROS
 %include "stdint.i"
 
 %include "lldb/lldb-defines.h"
 %include "lldb/lldb-enumerations.h"
 %include "lldb/lldb-forward.h"
 %include "lldb/lldb-types.h"
 
 /* Forward declaration of SB classes. */