This is an archive of the discontinued LLVM Phabricator instance.

[LLVM][MC] Disable cfi-version test for aarch64-pc-windows*
ClosedPublic

Authored by omjavaid on Sep 29 2022, 1:39 AM.

Details

Summary

This patch disables MC/ELF/cfi-version.ll test as windows does not emit
.debug_frame needed by the test. This was previously disabled for arm64
but windows on arm uses aarch64-pc-windows* triple. Replacing arm64 with
aarch64 to accomodate windows aarch64 triple(s).

Diff Detail

Event Timeline

omjavaid created this revision.Sep 29 2022, 1:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2022, 1:39 AM
omjavaid requested review of this revision.Sep 29 2022, 1:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2022, 1:39 AM

Is target_triple some normalised triple because I do see some arm64-windows in the tests. E.g. llvm/test/CodeGen/AArch64/arm64-windows-tailcall.ll and llvm/test/MC/AArch64/arm64ec.s.

Checking for both would be fine (I half expect that at least clang would accept either, it's not very picky).

omjavaid updated this revision to Diff 463805.Sep 29 2022, 2:16 AM

As suggested I have accomodated both arm64 and aarch64.

This revision is now accepted and ready to land.Sep 29 2022, 2:32 AM
This revision was landed with ongoing or failed builds.Sep 29 2022, 2:38 AM
This revision was automatically updated to reflect the committed changes.
MaskRay added a comment.EditedSep 29 2022, 1:25 PM

Any idea for windows-gnu|windows-msvc|aix, which system uses arm64 as the canonical target triple name? I think all use aarch64 except arm64 for macOS/iOS?