This is an archive of the discontinued LLVM Phabricator instance.

Differential D134787

[ARM64EC] Add arm64ec for getArchName
ClosedPublic

Authored by bcl5980 on Sep 27 2022, 9:00 PM.

Details

Reviewers
efriedma
mstorsjo
Commits
rG0346f78a6f68: [ARM64EC] Add arm64ec for getArchName
Summary

Followup D125412, return the correct arch name for Arm64EC

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy
60,040 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test

Event Timeline

bcl5980 created this revision.Sep 27 2022, 9:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 9:00 PM
Herald added subscribers: hiraditya, kristof.beyls. · View Herald Transcript
bcl5980 requested review of this revision.Sep 27 2022, 9:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 9:00 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B189079: Diff 463412.Sep 27 2022, 10:04 PM
bcl5980 added a child revision: D134788: [ARM64EC][clang-cl] Add arm64EC test; NFC.Sep 27 2022, 11:00 PM
mstorsjo accepted this revision.Sep 28 2022, 3:17 AM

LGTM

Is there any testcase that could be added (e.g. for unittests for the Triple class) where this change makes a difference?

This revision is now accepted and ready to land.Sep 28 2022, 3:17 AM
bcl5980 updated this revision to Diff 463508.Sep 28 2022, 5:14 AM

add test

Harbormaster completed remote builds in B189141: Diff 463508.Sep 28 2022, 5:52 AM
bcl5980 updated this revision to Diff 463580.Sep 28 2022, 8:55 AM

correct test

Harbormaster completed remote builds in B189191: Diff 463580.Sep 28 2022, 9:35 AM
efriedma accepted this revision.Sep 28 2022, 11:33 AM
mstorsjo accepted this revision.Sep 28 2022, 11:47 AM

LGTM, thanks! This test does indeed now test what I'd expect for this change.

Closed by commit rG0346f78a6f68: [ARM64EC] Add arm64ec for getArchName (authored by bcl5980). · Explain WhySep 28 2022, 6:05 PM
This revision was automatically updated to reflect the committed changes.
bcl5980 added a commit: rG0346f78a6f68: [ARM64EC] Add arm64ec for getArchName.
bcl5980 removed a child revision: D134788: [ARM64EC][clang-cl] Add arm64EC test; NFC.Sep 28 2022, 6:12 PM

Revision Contents

PathSize
llvm/
lib/
Support/
4 lines

Diff 463412

llvm/lib/Support/Triple.cpp

Show First 20 Lines • Show All 1,143 Lines • ▼ Show 20 LinesStringRef Triple::getArchName(ArchType Kind, SubArchType SubArch) const {
case Triple::mips64: case Triple::mips64:
if (SubArch == MipsSubArch_r6) if (SubArch == MipsSubArch_r6)
return "mipsisa64r6"; return "mipsisa64r6";
break; break;
case Triple::mips64el: case Triple::mips64el:
if (SubArch == MipsSubArch_r6) if (SubArch == MipsSubArch_r6)
return "mipsisa64r6el"; return "mipsisa64r6el";
break; break;
case Triple::aarch64:
if (SubArch == AArch64SubArch_arm64ec)
return "arm64ec";
break;
default: default:
break; break;
} }
return getArchTypeName(Kind); return getArchTypeName(Kind);
} }
StringRef Triple::getVendorName() const { StringRef Triple::getVendorName() const {
StringRef Tmp = StringRef(Data).split('-').second; // Strip first component StringRef Tmp = StringRef(Data).split('-').second; // Strip first component
▲ Show 20 Lines • Show All 807 Lines • Show Last 20 Lines