This is an archive of the discontinued LLVM Phabricator instance.

Differential D134760

[mlir][sparse] fix signed/unsigned warning
ClosedPublic

Authored by aartbik on Sep 27 2022, 1:11 PM.

Details

Reviewers
bixia
nicolasvasilache
wrengr
Commits
rG1379596e9dd7: [mlir][sparse] fix signed/unsigned warning

Diff Detail

Event Timeline

aartbik created this revision.Sep 27 2022, 1:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 1:11 PM
Herald added subscribers: anlunx, bzcheeseman, sdasgup3 and 18 others. · View Herald Transcript
aartbik requested review of this revision.Sep 27 2022, 1:11 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptSep 27 2022, 1:11 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B189014: Diff 463321.Sep 27 2022, 1:43 PM
wrengr accepted this revision.Sep 27 2022, 1:54 PM

Notably, getShape returns ArrayRef<int64_t>, so this change is perfectly sound (in addition to removing the warning)

This revision is now accepted and ready to land.Sep 27 2022, 1:54 PM
Closed by commit rG1379596e9dd7: [mlir][sparse] fix signed/unsigned warning (authored by aartbik). · Explain WhySep 27 2022, 1:57 PM
This revision was automatically updated to reflect the committed changes.
aartbik added a commit: rG1379596e9dd7: [mlir][sparse] fix signed/unsigned warning.

Revision Contents

PathSize
mlir/
lib/
Dialect/
SparseTensor/
IR/
2 lines

Diff 463333

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

Show First 20 Lines • Show All 511 Lines • ▼ Show 20 LinesLogicalResult SortOp::verify() {
auto n = getN().getDefiningOp<arith::ConstantIndexOp>(); auto n = getN().getDefiningOp<arith::ConstantIndexOp>();
Type xtp = getXs().front().getType().cast<MemRefType>().getElementType(); Type xtp = getXs().front().getType().cast<MemRefType>().getElementType();
auto checkTypes = [&](ValueRange operands, auto checkTypes = [&](ValueRange operands,
bool checkEleType = true) -> LogicalResult { bool checkEleType = true) -> LogicalResult {
for (Value opnd : operands) { for (Value opnd : operands) {
MemRefType mtp = opnd.getType().cast<MemRefType>(); MemRefType mtp = opnd.getType().cast<MemRefType>();
uint64_t dim = mtp.getShape()[0]; int64_t dim = mtp.getShape()[0];
// We can't check the size of dynamic dimension at compile-time, but all // We can't check the size of dynamic dimension at compile-time, but all
// xs and ys should have a dimension not less than n at runtime. // xs and ys should have a dimension not less than n at runtime.
if (n && dim != ShapedType::kDynamicSize && dim < n.value()) if (n && dim != ShapedType::kDynamicSize && dim < n.value())
return emitError(llvm::formatv("xs and ys need to have a dimension >= n" return emitError(llvm::formatv("xs and ys need to have a dimension >= n"
": {0} < {1}", ": {0} < {1}",
dim, n.value())); dim, n.value()));
if (checkEleType && xtp != mtp.getElementType()) if (checkEleType && xtp != mtp.getElementType())
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines