This is an archive of the discontinued LLVM Phabricator instance.

Differential D134517

[lldb][COFF] Load absolute symbols from COFF symbol table
ClosedPublic

Authored by alvinhochun on Sep 22 2022, 11:55 PM.

Details

Reviewers
labath
DavidSpickett
mstorsjo
Commits
rG7ebff6ab26aa: [lldb][COFF] Load absolute symbols from COFF symbol table
Summary

Depends on D134426

Diff Detail

Event Timeline

alvinhochun created this revision.Sep 22 2022, 11:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 11:55 PM
alvinhochun requested review of this revision.Sep 22 2022, 11:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 11:55 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B188340: Diff 462398.Sep 22 2022, 11:55 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptSep 22 2022, 11:55 PM
labath accepted this revision.Sep 23 2022, 4:00 AM
This revision is now accepted and ready to land.Sep 23 2022, 4:00 AM
alvinhochun updated this revision to Diff 462479.Sep 23 2022, 7:29 AM

Rebased on parent

Harbormaster completed remote builds in B188403: Diff 462479.Sep 23 2022, 7:29 AM
Closed by commit rG7ebff6ab26aa: [lldb][COFF] Load absolute symbols from COFF symbol table (authored by alvinhochun, committed by mstorsjo). · Explain WhySep 28 2022, 2:58 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG7ebff6ab26aa: [lldb][COFF] Load absolute symbols from COFF symbol table.

Revision Contents

PathSize
lldb/
source/
Plugins/
ObjectFile/
PECOFF/
3 lines
test/
Shell/
ObjectFile/
PECOFF/
13 lines

Diff 462479

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

Show First 20 Lines • Show All 824 Lines • ▼ Show 20 Lines if (section_number >= 1) {
// It is possible for a symbol to be exported in a different name // It is possible for a symbol to be exported in a different name
// from its original. In this case keep both entries so lookup using // from its original. In this case keep both entries so lookup using
// either names will work. If this symbol has an invalid type, replace // either names will work. If this symbol has an invalid type, replace
// it with the type from the export symbol. // it with the type from the export symbol.
if (symbol.GetType() == lldb::eSymbolTypeInvalid) if (symbol.GetType() == lldb::eSymbolTypeInvalid)
symbol.SetType(exported->GetType()); symbol.SetType(exported->GetType());
} }
} }
} else if (section_number == llvm::COFF::IMAGE_SYM_ABSOLUTE) {
symbol.GetAddressRef() = Address(coff_sym_ref.getValue());
symbol.SetType(lldb::eSymbolTypeAbsolute);
} }
symtab.AddSymbol(symbol); symtab.AddSymbol(symbol);
} }
} }
ObjectFilePECOFF::rva_symbol_list_t ObjectFilePECOFF::rva_symbol_list_t
ObjectFilePECOFF::AppendFromExportTable(SectionList *sect_list, ObjectFilePECOFF::AppendFromExportTable(SectionList *sect_list,
Symtab &symtab) { Symtab &symtab) {
▲ Show 20 Lines • Show All 542 Lines • Show Last 20 Lines

lldb/test/Shell/ObjectFile/PECOFF/symbol.yaml

# RUN: yaml2obj %s -o %t # RUN: yaml2obj %s -o %t
# RUN: lldb-test symbols %t | FileCheck %s # RUN: lldb-test symbols %t | FileCheck %s
## The .file symbol isn't checked, but is included to test that the symbol ## The .file symbol isn't checked, but is included to test that the symbol
## table iteration handles cases with a symbol with more than one aux symbol. ## table iteration handles cases with a symbol with more than one aux symbol.
# CHECK: Type File Address/Value {{.*}} Size Flags Name # CHECK: Type File Address/Value {{.*}} Size Flags Name
# CHECK: Code 0x0000000040001000 0x{{[0-9a-f]+}} 0x{{[0-9a-f]+}} entry # CHECK: Code 0x0000000040001000 0x{{[0-9a-f]+}} 0x{{[0-9a-f]+}} entry
# CHECK: 0x0000000040002000 0x{{[0-9a-f]+}} 0x{{[0-9a-f]+}} variable # CHECK: 0x0000000040002000 0x{{[0-9a-f]+}} 0x{{[0-9a-f]+}} variable
# CHECK: Absolute 0x00000000deadbeef 0x{{[0-9a-f]+}} 0x{{[0-9a-f]+}} absolute_symbol
--- !COFF --- !COFF
OptionalHeader: OptionalHeader:
AddressOfEntryPoint: 4096 AddressOfEntryPoint: 4096
ImageBase: 1073741824 ImageBase: 1073741824
SectionAlignment: 4096 SectionAlignment: 4096
FileAlignment: 512 FileAlignment: 512
MajorOperatingSystemVersion: 6 MajorOperatingSystemVersion: 6
▲ Show 20 Lines • Show All 100 Lines • ▼ Show 20 Lines - Name: entry
ComplexType: IMAGE_SYM_DTYPE_FUNCTION ComplexType: IMAGE_SYM_DTYPE_FUNCTION
StorageClass: IMAGE_SYM_CLASS_EXTERNAL StorageClass: IMAGE_SYM_CLASS_EXTERNAL
- Name: variable - Name: variable
Value: 0 Value: 0
SectionNumber: 2 SectionNumber: 2
SimpleType: IMAGE_SYM_TYPE_NULL SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_EXTERNAL StorageClass: IMAGE_SYM_CLASS_EXTERNAL
- Name: absolute_symbol
Value: 0xdeadbeef
SectionNumber: -1
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_STATIC
... ...