[NFC] check for UnreachableInst first as it is cheaper compared to getTerminatingDeoptimizeCall

[Peter]

llvm/lib/Transforms/Utils/BasicBlockUtils.cpp

603–604

Are we bitwise or two pointers of different type or is the parentheses wrong?

[hiraditya]

Fixed a typo and ran check-llvm

[hiraditya]

llvm/lib/Transforms/Utils/BasicBlockUtils.cpp

603–604

fixed. thanks for pointing it out.

[hiraditya]

ping: @Peter

[Peter]

It seems clang-format failed. Can you fix that?
git-clang-format returned an non-zero exit code 1

[hiraditya]

clang-format

[craig.topper]

LGTM

llvm/lib/Transforms/Utils/BasicBlockUtils.cpp

 }
 
 bool llvm::IsBlockFollowedByDeoptOrUnreachable(const BasicBlock *BB) {
   // Remember visited blocks to avoid infinite loop
   SmallPtrSet<const BasicBlock *, 8> VisitedBlocks;
   unsigned Depth = 0;
   while (BB && Depth++ < MaxDeoptOrUnreachableSuccessorCheckDepth &&
          VisitedBlocks.insert(BB).second) {
-    if (BB->getTerminatingDeoptimizeCall() ||
-        isa<UnreachableInst>(BB->getTerminator()))
+    if (isa<UnreachableInst>(BB->getTerminator()) ||
+        BB->getTerminatingDeoptimizeCall())
       return true;
     BB = BB->getUniqueSuccessor();
   }
   return false;
 }
 
 void llvm::ReplaceInstWithInst(Instruction *From, Instruction *To) {
   BasicBlock::iterator BI(From);