This is an archive of the discontinued LLVM Phabricator instance.

Differential D134447

[libc++][NFC] Fix some standard-mandated includes comments
ClosedPublic

Authored by philnik on Sep 22 2022, 9:05 AM.

Details

Reviewers
ldionne
Mordante
var-const
huixie90
Group Reviewers
Restricted Project
Commits
rG473a16050634: [libc++][NFC] Fix some standard-mandated includes comments

Diff Detail

Event Timeline

philnik created this revision.Sep 22 2022, 9:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 9:05 AM
philnik requested review of this revision.Sep 22 2022, 9:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 9:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B188189: Diff 462194.Sep 22 2022, 9:05 AM
ldionne accepted this revision.Sep 23 2022, 1:50 PM
This revision is now accepted and ready to land.Sep 23 2022, 1:50 PM
Mordante added a comment.Sep 25 2022, 6:30 AM

Thanks, I really like this. I haven't verified whether it's correct, I assume @ldionne did that.

Closed by commit rG473a16050634: [libc++][NFC] Fix some standard-mandated includes comments (authored by philnik). · Explain WhySep 27 2022, 12:12 PM
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG473a16050634: [libc++][NFC] Fix some standard-mandated includes comments.

Revision Contents

PathSize
libcxx/
include/
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
8 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 462194

libcxx/include/algorithm

Show First 20 Lines • Show All 1,893 Lines • ▼ Show 20 Lines
#include <__algorithm/swap_ranges.h> #include <__algorithm/swap_ranges.h>
#include <__algorithm/transform.h> #include <__algorithm/transform.h>
#include <__algorithm/unique.h> #include <__algorithm/unique.h>
#include <__algorithm/unique_copy.h> #include <__algorithm/unique_copy.h>
#include <__algorithm/unwrap_iter.h> #include <__algorithm/unwrap_iter.h>
#include <__algorithm/upper_bound.h> #include <__algorithm/upper_bound.h>
// standard-mandated includes // standard-mandated includes
// [algorithm.syn]
#include <initializer_list> #include <initializer_list>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if defined(_LIBCPP_HAS_PARALLEL_ALGORITHMS) && _LIBCPP_STD_VER >= 17 #if defined(_LIBCPP_HAS_PARALLEL_ALGORITHMS) && _LIBCPP_STD_VER >= 17
# include <__pstl_algorithm> # include <__pstl_algorithm>
Show All 15 Lines

libcxx/include/bitset

Show First 20 Lines • Show All 119 Lines • ▼ Show 20 Lines
#include <__functional/unary_function.h> #include <__functional/unary_function.h>
#include <__type_traits/is_char_like_type.h> #include <__type_traits/is_char_like_type.h>
#include <climits> #include <climits>
#include <cstddef> #include <cstddef>
#include <stdexcept> #include <stdexcept>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [bitset.syn]
#include <iosfwd> #include <iosfwd>
#include <string> #include <string>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
▲ Show 20 Lines • Show All 1,018 Lines • Show Last 20 Lines

libcxx/include/chrono

Show First 20 Lines • Show All 688 Lines • ▼ Show 20 Lines
#include <__chrono/year.h> #include <__chrono/year.h>
#include <__chrono/year_month.h> #include <__chrono/year_month.h>
#include <__chrono/year_month_day.h> #include <__chrono/year_month_day.h>
#include <__chrono/year_month_weekday.h> #include <__chrono/year_month_weekday.h>
#include <__config> #include <__config>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [time.syn]
#include <compare> #include <compare>
#if !defined(_LIBCPP_HAS_NO_LOCALIZATION) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) && _LIBCPP_STD_VER > 17 #if !defined(_LIBCPP_HAS_NO_LOCALIZATION) && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) && _LIBCPP_STD_VER > 17
# include <__chrono/formatter.h> # include <__chrono/formatter.h>
# include <__chrono/ostream.h> # include <__chrono/ostream.h>
# include <__chrono/parser_std_format_spec.h> # include <__chrono/parser_std_format_spec.h>
# include <__chrono/statically_widen.h> # include <__chrono/statically_widen.h>
#endif #endif
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#endif // _LIBCPP_CHRONO #endif // _LIBCPP_CHRONO

libcxx/include/cinttypes

Show First 20 Lines • Show All 230 Lines • ▼ Show 20 Lines
intmax_t wcstoimax(const wchar_t* restrict nptr, wchar_t** restrict endptr, int base); intmax_t wcstoimax(const wchar_t* restrict nptr, wchar_t** restrict endptr, int base);
uintmax_t wcstoumax(const wchar_t* restrict nptr, wchar_t** restrict endptr, int base); uintmax_t wcstoumax(const wchar_t* restrict nptr, wchar_t** restrict endptr, int base);
} // std } // std
*/ */
#include <__assert> // all public C++ headers provide the assertion handler #include <__assert> // all public C++ headers provide the assertion handler
#include <__config> #include <__config>
// standard-mandated includes
// [cinttypes.syn]
#include <cstdint> #include <cstdint>
#include <inttypes.h> #include <inttypes.h>
#ifndef _LIBCPP_INTTYPES_H #ifndef _LIBCPP_INTTYPES_H
# error <cinttypes> tried including <inttypes.h> but didn't find libc++'s <inttypes.h> header. \ # error <cinttypes> tried including <inttypes.h> but didn't find libc++'s <inttypes.h> header. \
This usually means that your header search paths are not configured properly. \ This usually means that your header search paths are not configured properly. \
The header search paths should contain the C++ Standard Library headers before \ The header search paths should contain the C++ Standard Library headers before \
Show All 21 Lines

libcxx/include/coroutine

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
#include <__config> #include <__config>
#include <__coroutine/coroutine_handle.h> #include <__coroutine/coroutine_handle.h>
#include <__coroutine/coroutine_traits.h> #include <__coroutine/coroutine_traits.h>
#include <__coroutine/noop_coroutine_handle.h> #include <__coroutine/noop_coroutine_handle.h>
#include <__coroutine/trivial_awaitables.h> #include <__coroutine/trivial_awaitables.h>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [coroutine.syn]
#include <compare> #include <compare>
#ifndef _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER #ifndef _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20 #if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
# include <iosfwd> # include <iosfwd>
#endif #endif
#endif // _LIBCPP_COROUTINE #endif // _LIBCPP_COROUTINE

libcxx/include/filesystem

Show First 20 Lines • Show All 443 Lines • ▼ Show 20 Lines
#include <__filesystem/perm_options.h> #include <__filesystem/perm_options.h>
#include <__filesystem/perms.h> #include <__filesystem/perms.h>
#include <__filesystem/recursive_directory_iterator.h> #include <__filesystem/recursive_directory_iterator.h>
#include <__filesystem/space_info.h> #include <__filesystem/space_info.h>
#include <__filesystem/u8path.h> #include <__filesystem/u8path.h>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [fs.filesystem.syn]
#include <compare> #include <compare>
#if defined(_LIBCPP_HAS_NO_FILESYSTEM_LIBRARY) #if defined(_LIBCPP_HAS_NO_FILESYSTEM_LIBRARY)
# error "The <filesystem> library is not supported since libc++ has been configured without support for a filesystem." # error "The <filesystem> library is not supported since libc++ has been configured without support for a filesystem."
#endif #endif
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#endif // _LIBCPP_FILESYSTEM #endif // _LIBCPP_FILESYSTEM

libcxx/include/ios

Show First 20 Lines • Show All 218 Lines • ▼ Show 20 Lines
#include <__assert> // all public C++ headers provide the assertion handler #include <__assert> // all public C++ headers provide the assertion handler
#include <__ios/fpos.h> #include <__ios/fpos.h>
#include <__locale> #include <__locale>
#include <__utility/swap.h> #include <__utility/swap.h>
#include <system_error> #include <system_error>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [ios.syn]
#include <iosfwd> #include <iosfwd>
#if !defined(_LIBCPP_HAS_NO_ATOMIC_HEADER) #if !defined(_LIBCPP_HAS_NO_ATOMIC_HEADER)
#include <atomic> // for __xindex_ #include <atomic> // for __xindex_
#endif #endif
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
▲ Show 20 Lines • Show All 805 Lines • Show Last 20 Lines

libcxx/include/iostream

Show All 32 Lines
*/ */
#include <__assert> // all public C++ headers provide the assertion handler #include <__assert> // all public C++ headers provide the assertion handler
#include <__config> #include <__config>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [iostream.syn]
#include <ios> #include <ios>
#include <istream> #include <istream>
#include <ostream> #include <ostream>
#include <streambuf> #include <streambuf>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
Show All 18 Lines

libcxx/include/iterator

Show First 20 Lines • Show All 711 Lines • ▼ Show 20 Lines
#include <__iterator/reverse_access.h> #include <__iterator/reverse_access.h>
#include <__iterator/reverse_iterator.h> #include <__iterator/reverse_iterator.h>
#include <__iterator/size.h> #include <__iterator/size.h>
#include <__iterator/sortable.h> #include <__iterator/sortable.h>
#include <__iterator/unreachable_sentinel.h> #include <__iterator/unreachable_sentinel.h>
#include <__iterator/wrap_iter.h> #include <__iterator/wrap_iter.h>
#include <__memory/addressof.h> #include <__memory/addressof.h>
#include <__memory/pointer_traits.h> #include <__memory/pointer_traits.h>
#include <compare>
#include <concepts> // Mandated by the Standard.
#include <cstddef> #include <cstddef>
#include <initializer_list> #include <initializer_list>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// standard-mandated includes
// [iterator.synopsis]
#include <compare>
#include <concepts>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20 #if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
# include <exception> # include <exception>
# include <new> # include <new>
# include <typeinfo> # include <typeinfo>
# include <utility> # include <utility>
#endif #endif
#endif // _LIBCPP_ITERATOR #endif // _LIBCPP_ITERATOR

libcxx/include/memory

Show First 20 Lines • Show All 880 Lines • ▼ Show 20 Lines
#include <__memory/shared_ptr.h> #include <__memory/shared_ptr.h>
#include <__memory/temporary_buffer.h> #include <__memory/temporary_buffer.h>
#include <__memory/uninitialized_algorithms.h> #include <__memory/uninitialized_algorithms.h>
#include <__memory/unique_ptr.h> #include <__memory/unique_ptr.h>
#include <__memory/uses_allocator.h> #include <__memory/uses_allocator.h>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [memory.syn]
#include <compare> #include <compare>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if defined(_LIBCPP_HAS_PARALLEL_ALGORITHMS) && _LIBCPP_STD_VER >= 17 #if defined(_LIBCPP_HAS_PARALLEL_ALGORITHMS) && _LIBCPP_STD_VER >= 17
# include <__pstl_memory> # include <__pstl_memory>
Show All 17 Lines

libcxx/include/optional

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines
#include <__utility/swap.h> #include <__utility/swap.h>
#include <initializer_list> #include <initializer_list>
#include <new> #include <new>
#include <stdexcept> #include <stdexcept>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [optional.syn]
#include <compare> #include <compare>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
namespace std // purposefully not using versioning namespace namespace std // purposefully not using versioning namespace
{ {
▲ Show 20 Lines • Show All 1,405 Lines • Show Last 20 Lines

libcxx/include/queue

Show First 20 Lines • Show All 226 Lines • ▼ Show 20 Lines
#include <__memory/uses_allocator.h> #include <__memory/uses_allocator.h>
#include <__utility/forward.h> #include <__utility/forward.h>
#include <deque> #include <deque>
#include <type_traits> #include <type_traits>
#include <vector> #include <vector>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [queue.syn]
#include <compare> #include <compare>
#include <initializer_list> #include <initializer_list>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
▲ Show 20 Lines • Show All 721 Lines • Show Last 20 Lines

libcxx/include/random

Show First 20 Lines • Show All 1,713 Lines • ▼ Show 20 Lines
#include <__random/subtract_with_carry_engine.h> #include <__random/subtract_with_carry_engine.h>
#include <__random/uniform_int_distribution.h> #include <__random/uniform_int_distribution.h>
#include <__random/uniform_random_bit_generator.h> #include <__random/uniform_random_bit_generator.h>
#include <__random/uniform_real_distribution.h> #include <__random/uniform_real_distribution.h>
#include <__random/weibull_distribution.h> #include <__random/weibull_distribution.h>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [rand.synopsis]
#include <initializer_list> #include <initializer_list>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20 #if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
# include <algorithm> # include <algorithm>
Show All 12 Lines

libcxx/include/stack

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
#include <__iterator/iterator_traits.h> #include <__iterator/iterator_traits.h>
#include <__memory/uses_allocator.h> #include <__memory/uses_allocator.h>
#include <__utility/forward.h> #include <__utility/forward.h>
#include <deque> #include <deque>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [stack.syn]
#include <compare> #include <compare>
#include <initializer_list> #include <initializer_list>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
▲ Show 20 Lines • Show All 248 Lines • Show Last 20 Lines

libcxx/include/system_error

Show First 20 Lines • Show All 150 Lines • ▼ Show 20 Lines
#include <__functional/unary_function.h> #include <__functional/unary_function.h>
#include <__memory/addressof.h> #include <__memory/addressof.h>
#include <stdexcept> #include <stdexcept>
#include <string> #include <string>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [system.error.syn]
#include <compare> #include <compare>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
▲ Show 20 Lines • Show All 359 Lines • Show Last 20 Lines

libcxx/include/thread

Show First 20 Lines • Show All 94 Lines • ▼ Show 20 Lines
#include <cstddef> #include <cstddef>
#include <iosfwd> #include <iosfwd>
#include <system_error> #include <system_error>
#include <tuple> #include <tuple>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [thread.syn]
#include <compare> #include <compare>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
▲ Show 20 Lines • Show All 309 Lines • Show Last 20 Lines

libcxx/include/tuple

Show First 20 Lines • Show All 215 Lines • ▼ Show 20 Lines
#include <__utility/pair.h> #include <__utility/pair.h>
#include <__utility/piecewise_construct.h> #include <__utility/piecewise_construct.h>
#include <__utility/swap.h> #include <__utility/swap.h>
#include <cstddef> #include <cstddef>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [tuple.syn]
#include <compare> #include <compare>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
▲ Show 20 Lines • Show All 1,596 Lines • Show Last 20 Lines

libcxx/include/valarray

Show First 20 Lines • Show All 355 Lines • ▼ Show 20 Lines
#include <__utility/move.h> #include <__utility/move.h>
#include <__utility/swap.h> #include <__utility/swap.h>
#include <cmath> #include <cmath>
#include <cstddef> #include <cstddef>
#include <new> #include <new>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [valarray.syn]
#include <initializer_list> #include <initializer_list>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
▲ Show 20 Lines • Show All 4,564 Lines • Show Last 20 Lines

libcxx/include/variant

Show First 20 Lines • Show All 222 Lines • ▼ Show 20 Lines
#include <initializer_list> #include <initializer_list>
#include <limits> #include <limits>
#include <new> #include <new>
#include <tuple> #include <tuple>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
// [variant.syn]
#include <compare> #include <compare>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
▲ Show 20 Lines • Show All 1,582 Lines • Show Last 20 Lines