This is an archive of the discontinued LLVM Phabricator instance.

[flang] Write semantics test for atomic_define
ClosedPublic

Authored by ktras on Sep 20 2022, 9:42 AM.

Details

Summary

Write a semantics test for the atomic intrinsic subroutine, atomic_define.

Diff Detail

Event Timeline

ktras created this revision.Sep 20 2022, 9:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: jdoerfert. · View Herald Transcript
ktras requested review of this revision.Sep 20 2022, 9:42 AM
ktras updated this revision to Diff 461758.Sep 20 2022, 4:45 PM

Realized that I had multiple errors on the lines where I am trying to test a single error. Changed those calls so that they target one error.

rouson accepted this revision.Sep 22 2022, 10:21 AM

LGTM

flang/test/Semantics/atomic04.f90
13

Please add a comment to document any assumptions required for this code to be valid, e.g., the assumption that atomic_int_kind /= 1 (which is currently true but doesn't necessarily have to be true forevermore).

23

In lines 23-29, the second argument could sometimes be default_int_val to vary the testing regime.

This revision is now accepted and ready to land.Sep 22 2022, 10:21 AM
This revision was landed with ongoing or failed builds.Sep 26 2022, 9:59 PM
This revision was automatically updated to reflect the committed changes.
ktras marked 2 inline comments as done.