This is an archive of the discontinued LLVM Phabricator instance.

[Orc] Fix the SharedMemoryMapper dtor
ClosedPublic

Authored by aganea on Sep 19 2022, 12:46 PM.

Details

Summary

As briefly discussed on rG1134d3a03fac, fix the unintended copy while iterating on Reservations and add a mutex guard, to be symmetric with other usages of Reservations.

Diff Detail

Event Timeline

aganea created this revision.Sep 19 2022, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2022, 12:46 PM
aganea requested review of this revision.Sep 19 2022, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2022, 12:46 PM
argentite accepted this revision.Sep 20 2022, 6:08 AM

Thanks! I forgot about this.

This revision is now accepted and ready to land.Sep 20 2022, 6:08 AM
This revision was landed with ongoing or failed builds.Oct 5 2022, 9:17 AM
This revision was automatically updated to reflect the committed changes.