This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Document the format of _LIBCPP_VERSION
ClosedPublic

Authored by ldionne on Sep 19 2022, 8:29 AM.

Details

Reviewers
thieta
philnik
Group Reviewers
Restricted Project
Commits
rGad0dfb4f5e07: [libc++] Document the format of _LIBCPP_VERSION

Diff Detail

Event Timeline

ldionne created this revision.Sep 19 2022, 8:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2022, 8:29 AM
ldionne requested review of this revision.Sep 19 2022, 8:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2022, 8:29 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 461220.Sep 19 2022, 8:29 AM

Use XXYZZ instead of ABCDE.

thieta accepted this revision.Sep 19 2022, 8:30 AM

Want me to pick this to 15.0.1 if I bump the version there? It's completely safe and explains it so I say we should.

philnik accepted this revision.Sep 19 2022, 8:34 AM
This revision is now accepted and ready to land.Sep 19 2022, 8:34 AM

Want me to pick this to 15.0.1 if I bump the version there? It's completely safe and explains it so I say we should.

Since we're just about to change it to XXYYZZ, I would actually hold off with that. Let's keep this value undocumented in LLVM 15, and then we can ship it as documented and XXYYZZ in LLVM 16.

This revision was automatically updated to reflect the committed changes.