[clang][Interp] Properly destruct allocated Records

[tbaeder]

Summary

As discussed with @aaron.ballman on IRC.

This reverts https://reviews.llvm.org/rGa8843643cd75d0e93ebcf3f30b470d2b8e59868d

I have ASan enabled locally and with this patch, the test suite now works fine.

[erichkeane]

Other than the pedantry above, LGTM.

clang/lib/AST/Interp/Program.h

48

I SUSPECT that by a reading of our rules here, we aren't allowed to use auto here. That said, I'm sure I don't want to have you spell out the whole LHS.

THOUGH the name "It" is a little misleading, as this is NOT an iterator, it ends up being a std::pair or something I think...

[tbaeder]

clang/lib/AST/Interp/Program.h

48

Would RecordPair be better?

[erichkeane]

clang/lib/AST/Interp/Program.h

48

Sure, good enough.

Feel free to come up with whatever and commit.

[aaron.ballman]

LGTM as well (modulo Erich's comments).

clang/lib/AST/Interp/Program.h

 class Context;
 class Record;
 
 /// The program contains and links the bytecode for all functions.
 class Program final {
 public:
   Program(Context &Ctx) : Ctx(Ctx) {}
 
+  ~Program() {
+    // Records might actually allocate memory themselves, but they
+    // are allocated using a BumpPtrAllocator. Call their desctructors
+    // here manually so they are properly freeing their resources.
+    for (auto RecordPair : Records)
+      RecordPair.second->~Record();
+  }
+
   /// Marshals a native pointer to an ID for embedding in bytecode.
   unsigned getOrCreateNativePointer(const void *Ptr);
 
   /// Returns the value of a marshalled native pointer.
   const void *getNativePointer(unsigned Idx);
 
   /// Emits a string literal among global data.
   unsigned createGlobalString(const StringLiteral *S);

clang/test/AST/Interp/references.cpp

constexpr int testGetValue() {
   return values[2];
 }
 static_assert(testGetValue() == 30, "");
 
 // FIXME: ExprWithCleanups + MaterializeTemporaryExpr not implemented
 constexpr const int &MCE = 1; // expected-error{{must be initialized by a constant expression}}
 
 
-#if 0
 struct S {
   int i, j;
 };
 
 constexpr int RefToMemberExpr() {
   S s{1, 2};
 
   int &j = s.i;
   j += 10;
 
   return j;
 }
 // FIXME: Should be accepted.
-static_assert(RefToMemberExpr() == 11, "");
-#endif
+static_assert(RefToMemberExpr() == 11, ""); // expected-error {{not an integral constant expression}}