This is an archive of the discontinued LLVM Phabricator instance.

Differential D133893

[mlir][ods] Add cppClassName to ConfinedType
ClosedPublic

Authored by Mogball on Sep 14 2022, 1:44 PM.

Details

Reviewers
rriddle
antiagainst
Commits
rG9eec5284c794: [mlir][ods] Add cppClassName to ConfinedType
Summary

So ODS can generate OneTypedResult when a ConfinedType is used as a
result type.

Diff Detail

Event Timeline

Mogball created this revision.Sep 14 2022, 1:44 PM
Herald added a reviewer: antiagainst. · View Herald TranscriptSep 14 2022, 1:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 18 others. · View Herald Transcript
Mogball requested review of this revision.Sep 14 2022, 1:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2022, 1:44 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle added inline comments.Sep 14 2022, 1:50 PM
mlir/include/mlir/IR/OpBase.td
364–365

This is going to overwrite the provided cppClassName. I would expect a user provided cppClassName to override the one coming from the type.

Mogball added inline comments.Sep 14 2022, 1:55 PM
mlir/include/mlir/IR/OpBase.td
364–365

Oh, that one is a misnomer. It should be cppBaseClassName.

Harbormaster completed remote builds in B186708: Diff 460205.Sep 14 2022, 2:35 PM
Mogball updated this revision to Diff 460248.Sep 14 2022, 3:15 PM
Mogball marked an inline comment as done.

Dont overwrite user-provided cppClassName

rriddle accepted this revision.Sep 14 2022, 3:24 PM
This revision is now accepted and ready to land.Sep 14 2022, 3:24 PM
Harbormaster completed remote builds in B186739: Diff 460248.Sep 14 2022, 3:35 PM
Closed by commit rG9eec5284c794: [mlir][ods] Add cppClassName to ConfinedType (authored by Mogball). · Explain WhySep 14 2022, 6:16 PM
This revision was automatically updated to reflect the committed changes.
Mogball added a commit: rG9eec5284c794: [mlir][ods] Add cppClassName to ConfinedType.

Revision Contents

PathSize
mlir/
include/
mlir/
IR/
2 lines

Diff 460279

mlir/include/mlir/IR/OpBase.td

Show First 20 Lines • Show All 353 Lines • ▼ Show 20 Linesclass AllOfType<list<Type> allowedTypes, string summary = "",
And<!foreach(allowedType, allowedTypes, allowedType.predicate)>, And<!foreach(allowedType, allowedTypes, allowedType.predicate)>,
!if(!eq(summary, ""), !if(!eq(summary, ""),
!interleave(!foreach(t, allowedTypes, t.summary), " and "), !interleave(!foreach(t, allowedTypes, t.summary), " and "),
summary), summary),
cppClassName>; cppClassName>;
// A type that satisfies additional predicates. // A type that satisfies additional predicates.
class ConfinedType<Type type, list<Pred> predicates, string summary = "", class ConfinedType<Type type, list<Pred> predicates, string summary = "",
string cppClassName = "::mlir::Type"> : Type< string cppClassName = type.cppClassName> : Type<
And<!listconcat([type.predicate], !foreach(pred, predicates, pred))>, And<!listconcat([type.predicate], !foreach(pred, predicates, pred))>,
summary, cppClassName>; summary, cppClassName>;
rriddleUnsubmitted
Done
ReplyInline Actions

This is going to overwrite the provided cppClassName. I would expect a user provided cppClassName to override the one coming from the type.

rriddle: This is going to overwrite the provided cppClassName. I would expect a user provided…
MogballAuthorUnsubmitted
Done
ReplyInline Actions

Oh, that one is a misnomer. It should be cppBaseClassName.

Mogball: Oh, that one is a misnomer. It should be `cppBaseClassName`.
// Integer types. // Integer types.
// Any integer type irrespective of its width and signedness semantics. // Any integer type irrespective of its width and signedness semantics.
def AnyInteger : Type<CPred<"$_self.isa<::mlir::IntegerType>()">, "integer", def AnyInteger : Type<CPred<"$_self.isa<::mlir::IntegerType>()">, "integer",
"::mlir::IntegerType">; "::mlir::IntegerType">;
// Any integer type (regardless of signedness semantics) of a specific width. // Any integer type (regardless of signedness semantics) of a specific width.
class AnyI<int width> class AnyI<int width>
▲ Show 20 Lines • Show All 2,067 Lines • Show Last 20 Lines