This is an archive of the discontinued LLVM Phabricator instance.

Differential D133859

[flang][driver]Fix broken PowerPC tests
ClosedPublic

Authored by Leporacanthicus on Sep 14 2022, 7:13 AM.

Details

Reviewers
awarzynski
Commits
rG9067de2a4314: [flang][driver]Fix broken PowerPC tests
Summary

Tests don't work on PPC since return instruciton is't called ret (apparently)

Diff Detail

Event Timeline

Leporacanthicus created this revision.Sep 14 2022, 7:13 AM
Herald added a reviewer: awarzynski. · View Herald TranscriptSep 14 2022, 7:13 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 20 others. · View Herald Transcript
Leporacanthicus requested review of this revision.Sep 14 2022, 7:13 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache, jdoerfert. · View Herald TranscriptSep 14 2022, 7:13 AM
awarzynski added a comment.Sep 14 2022, 7:25 AM

Tests don't work on PPC since return instruciton is't called ret (apparently)

Yes, I believe that it's blr rather than a variant of ret. Thanks for catching this. Just a minor suggestion - could you add a comment in the test?

flang/test/Driver/emit-asm-from-mlir.mlir
2

Could you add a comment that only architectures for which a ret instruction (or some variant of that) is generated?

Harbormaster completed remote builds in B186613: Diff 460076.Sep 14 2022, 7:26 AM
awarzynski accepted this revision.Sep 14 2022, 7:26 AM

Accepting as is - my suggestion can be addressed before merging. Thank you!

This revision is now accepted and ready to land.Sep 14 2022, 7:26 AM
Closed by commit rG9067de2a4314: [flang][driver]Fix broken PowerPC tests (authored by MatsPetersson). · Explain WhySep 14 2022, 8:34 AM
This revision was automatically updated to reflect the committed changes.
MatsPetersson added a commit: rG9067de2a4314: [flang][driver]Fix broken PowerPC tests.

Revision Contents

PathSize
flang/
test/
Driver/
3 lines

Diff 460110

flang/test/Driver/emit-asm-from-mlir.mlir

// REQUIRES: aarch64-registered-target || x86-registered-target || arm-registered-target
// Above restricts the test to those architectures that match "ret" to return
awarzynskiUnsubmitted
Not Done
ReplyInline Actions

Could you add a comment that only architectures for which a ret instruction (or some variant of that) is generated?

awarzynski: Could you add a comment that only architectures for which a `ret` instruction (or some variant…
// from a function.
// Verify that the driver can consume MLIR/FIR files. // Verify that the driver can consume MLIR/FIR files.
// RUN: %flang_fc1 -S %s -o - | FileCheck %s // RUN: %flang_fc1 -S %s -o - | FileCheck %s
// CHECK-LABEL: foo: // CHECK-LABEL: foo:
// CHECK: ret // CHECK: ret
func.func @foo() { func.func @foo() {
return return
} }