Page MenuHomePhabricator

[flang][driver]Fix broken PowerPC tests
ClosedPublic

Authored by Leporacanthicus on Sep 14 2022, 7:13 AM.

Details

Summary

Tests don't work on PPC since return instruciton is't called ret (apparently)

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Leporacanthicus requested review of this revision.Sep 14 2022, 7:13 AM

Tests don't work on PPC since return instruciton is't called ret (apparently)

Yes, I believe that it's blr rather than a variant of ret. Thanks for catching this. Just a minor suggestion - could you add a comment in the test?

flang/test/Driver/emit-asm-from-mlir.mlir
2

Could you add a comment that only architectures for which a ret instruction (or some variant of that) is generated?

awarzynski accepted this revision.Sep 14 2022, 7:26 AM

Accepting as is - my suggestion can be addressed before merging. Thank you!

This revision is now accepted and ready to land.Sep 14 2022, 7:26 AM
This revision was automatically updated to reflect the committed changes.