[MLIR] Fix toy lit substitutions

[csigg]

Summary

The tools are called e.g. toyc-ch1, not toy-ch1.

Add missing toyc-ch6/7.

It turns out that the other substitutions are not needed more by specific circumstances rather than by design:
The lit test exec root is set to build/mlir/test, which is where all the test tools are placed by CMake and we wouldn't need to substitute them at all.
We shouldn't rely on this assumption though, because it will make things harder for standalone tests and other build systems.

[csigg]

Changing this revision to only fix the toy substitutions.

It turns out that the other substitutions are not needed more by specific circumstances rather than by design:
The lit test exec root is set to build/mlir/test, which is where all the test tools are placed by CMake and we wouldn't need the substitute them at all.
We shouldn't rely on this assumption though, because it will make things harder for standalone tests and other build systems.

[csigg]

Add missing toyc-ch6/7.

[mehdi_amini]

How are things working right now without this? Does it mean that these may not be useful actually?

[csigg]

In D133842#3789093, @mehdi_amini wrote:

How are things working right now without this? Does it mean that these may not be useful actually?

You might have missed the description of the previous diff:

It turns out that the other substitutions are not needed more by specific circumstances rather than by design:
The lit test exec root is set to build/mlir/test, which is where all the test tools are placed by CMake and we wouldn't need to substitute them at all.
We shouldn't rely on this assumption though, because it will make things harder for standalone tests and other build systems.

Does this make sense?

mlir/test/lit.cfg.py

tools = [
     'not',
 ]
 
 if config.enable_spirv_cpu_runner:
   tools.extend(['mlir-spirv-cpu-runner'])
 
 # The following tools are optional
 tools.extend([
-    ToolSubst('toy-ch1', unresolved='ignore'),
-    ToolSubst('toy-ch2', unresolved='ignore'),
-    ToolSubst('toy-ch3', unresolved='ignore'),
-    ToolSubst('toy-ch4', unresolved='ignore'),
-    ToolSubst('toy-ch5', unresolved='ignore'),
+    ToolSubst('toyc-ch1', unresolved='ignore'),
+    ToolSubst('toyc-ch2', unresolved='ignore'),
+    ToolSubst('toyc-ch3', unresolved='ignore'),
+    ToolSubst('toyc-ch4', unresolved='ignore'),
+    ToolSubst('toyc-ch5', unresolved='ignore'),
+    ToolSubst('toyc-ch6', unresolved='ignore'),
+    ToolSubst('toyc-ch7', unresolved='ignore'),
     ToolSubst('%mlir_lib_dir', config.mlir_lib_dir, unresolved='ignore'),
     ToolSubst('%mlir_src_dir', config.mlir_src_root, unresolved='ignore'),
 ])
 
 python_executable = config.python_executable
 # Python configuration with sanitizer requires some magic preloading. This will only work on clang/linux.
 # TODO: detect Darwin/Windows situation (or mark these tests as unsupported on these platforms).
 if "asan" in config.available_features and "Linux" in config.host_os: