[test][clang] run test for lld emitting dwarf-aranages only if lld is presented

[azat]

Summary

Fixes: https://reviews.llvm.org/D133092
CI: https://lab.llvm.org/buildbot/#/builders/109/builds/46592

[hokein]

This looks good to me, I'm going to land this for you once I confirm that it fixes the test failure (we can address any post comments from dblaikie@).

[alexgatea]

Hi
This test case is still failing for me due to the lines without -fuse-ld=ldd:

// RUN: %clang -### -target x86_64-unknown-linux -flto -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LDGARANGE %s
// RUN: %clang -### -target x86_64-unknown-linux -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LDGARANGE %s

Can you please fix this?

[azat]

Can you please fix this?

It should be fixed in https://reviews.llvm.org/D133847

[alexgatea]

It should be fixed in https://reviews.llvm.org/D133847

Ah I didn't see that. Thank you!

[vitalybuka]

the test crashes with sanitizers https://lab.llvm.org/buildbot/#/builders/5/builds/27437

[azat]

the test crashes with sanitizers https://lab.llvm.org/buildbot/#/builders/5/builds/27437

yep, this should be fixed in https://reviews.llvm.org/D133847

[thakis]

As far as I can tell, this broke check-clang everywhere. (See e.g.: https://lab.llvm.org/buildbot/#/builders/139/builds/28039 and many of the bots on https://lab.llvm.org/buildbot/#/console

Before landing changes, please:

• run tests locally
• wait for the presubmit bots to post a success message on your phab review

After landing changes, please:

• watch the bots
• if they turn red, either quickly fix or quickly revert

Please don't land a change and then keep bots red for over 8 hours.

[thakis]

Reverted in db6a53450facdfead8b0c8d20cfa361a785945fd for now.

[azat]

@thakis Thanks for taking a look!

Actually initially the problem had been introduced in https://reviews.llvm.org/D133092
I've run tests locally, however I did have lld in a system, so I did not noticed the problem.
And CI did not find the problem either, since I guess it also has lld.

Final fix for this problem should be - https://reviews.llvm.org/D133847

clang/test/Driver/debug-options-lld.c

+// REQUIRES: lld
+// Check that lld will emit dwarf aranges.
+
+// RUN: %clang -### -target x86_64-unknown-linux -c -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=GARANGE %s
+// RUN: %clang -### -target x86_64-unknown-linux -flto -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LDGARANGE %s
+// RUN: %clang -### -target x86_64-unknown-linux -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LDGARANGE %s
+// RUN: %clang -### -target x86_64-unknown-linux -fuse-ld=lld -flto -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LLDGARANGE %s
+// RUN: %clang -### -target x86_64-unknown-linux -fuse-ld=lld -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LLDGARANGE %s
+//
+// GARANGE-DAG: -generate-arange-section
+// LDGARANGE-NOT: {{".*lld.*"}} {{.*}} "-generate-arange-section"
+// LLDGARANGE: {{".*lld.*"}} {{.*}} "-generate-arange-section"

clang/test/Driver/debug-options.c

 //
 // RUN: %clang -### -c -fdebug-ranges-base-address %s 2>&1 | FileCheck -check-prefix=RNGBSE %s
 // RUN: %clang -### -c %s 2>&1 | FileCheck -check-prefix=NORNGBSE %s
 // RUN: %clang -### -c -fdebug-ranges-base-address -fno-debug-ranges-base-address %s 2>&1 | FileCheck -check-prefix=NORNGBSE %s
 //
 // RUN: %clang -### -c -glldb %s 2>&1 | FileCheck -check-prefix=NOPUB %s
 // RUN: %clang -### -c -glldb -gno-pubnames %s 2>&1 | FileCheck -check-prefix=NOPUB %s
 //
-// RUN: %clang -### -target x86_64-unknown-linux -c -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=GARANGE %s
-// RUN: %clang -### -target x86_64-unknown-linux -flto -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LDGARANGE %s
-// RUN: %clang -### -target x86_64-unknown-linux -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LDGARANGE %s
-// RUN: %clang -### -target x86_64-unknown-linux -fuse-ld=lld -flto -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LLDGARANGE %s
-// RUN: %clang -### -target x86_64-unknown-linux -fuse-ld=lld -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=LLDGARANGE %s
+// RUN: %clang -### -c -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=GARANGE %s
 //
 // RUN: %clang -### -fdebug-types-section -target x86_64-unknown-linux %s 2>&1 \
 // RUN:        | FileCheck -check-prefix=FDTS %s
 //
 // RUN: %clang -### -fdebug-types-section -fno-debug-types-section -target x86_64-unknown-linux %s 2>&1 \
 // RUN:        | FileCheck -check-prefix=NOFDTS %s
 //
 // RUN: %clang -### -fdebug-types-section -target wasm32-unknown-unknown %s 2>&1 \

 // NOPUB-NOT: -gpubnames
 //
 // PUB: -gpubnames
 //
 // RNGBSE: -fdebug-ranges-base-address
 // NORNGBSE-NOT: -fdebug-ranges-base-address
 //
 // GARANGE-DAG: -generate-arange-section
-// LDGARANGE-NOT: {{".*lld.*"}} {{.*}} "-generate-arange-section"
-// LLDGARANGE: {{".*lld.*"}} {{.*}} "-generate-arange-section"
 //
 // FDTS: "-mllvm" "-generate-type-units"
 // FDTSE: error: unsupported option '-fdebug-types-section' for target 'x86_64-apple-darwin'
 //
 // NOFDTS-NOT: "-mllvm" "-generate-type-units"
 // NOFDTSE-NOT: error: unsupported option '-fdebug-types-section' for target 'x86_64-apple-darwin'
 //
 // CI-NOT: "-gno-column-info"