Now, when the filename contains lld, it does not filter correctly.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Presumably this would break if someone's build uses a tool suffix (so lld becomes lld-tot or something like that)? Perhaps lld[^"]*" would be better?
Are there other test cases that test something similar that we could look at to see how they work/more likely get something that works as well?
Presumably this would break if someone's build uses a tool suffix (so lld becomes lld-tot or something like that)? Perhaps lld[^"]*" would be better?
I thought about this too, but I found this in another test, so likely it should work...
Are there other test cases that test something similar that we could look at to see how they work/more likely get something that works as well?
This one is copied from clang/test/Driver/debug-options-lld.c
Anyway I need to resubmit the initial patch since it got reverted.
But I don't see close button here, only trusted users can do this?
Perhaps lld[^"]*" would be better?
But yeah, this looks better anyway. Applied your suggestion. New revision - https://reviews.llvm.org/D133875