This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Add nontemporal tests for big endian.
ClosedPublic

Authored by zjaffal on Sep 13 2022, 2:44 AM.

Diff Detail

Event Timeline

zjaffal created this revision.Sep 13 2022, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 2:44 AM
zjaffal requested review of this revision.Sep 13 2022, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 2:44 AM
fhahn added inline comments.Sep 13 2022, 2:45 AM
llvm/test/CodeGen/AArch64/nontemporal-load.ll
20

Looks like those are duplicated?

zjaffal updated this revision to Diff 459696.Sep 13 2022, 2:48 AM

remove redundant checks

fhahn accepted this revision.Sep 13 2022, 3:25 AM

LGTM, thanks for adding those extra tests!

This revision is now accepted and ready to land.Sep 13 2022, 3:25 AM

Shouldn't we fix big-endian at the same time? It's difficult to justify the benefit of adding known-broken tests.

fhahn added a comment.Sep 13 2022, 3:44 AM

Shouldn't we fix big-endian at the same time? It's difficult to justify the benefit of adding known-broken tests.

yeah we should fix the LDNP256 lowering for BE, pre-commit the test just makes it easier to see the changes for the fix. @zjaffal could you also put up a patch fixing the 256bit LDNP lowering for BE as follow-up?

zjaffal updated this revision to Diff 459731.Sep 13 2022, 6:20 AM

add missing flag

This revision was landed with ongoing or failed builds.Sep 14 2022, 5:52 AM
This revision was automatically updated to reflect the committed changes.