Partially implements:
- P1361 Integration of chrono with text formatting
Paths
| Differential D133663
[libc++][chrono] Implements formatter year. ClosedPublic Authored by Mordante on Sep 11 2022, 3:16 AM.
Details
Summary Partially implements:
Diff Detail
Unit TestsFailed Event TimelineMordante added a parent revision: D134031: [libc++][test] Adds format string helper..Sep 16 2022, 8:37 AM Mordante added a child revision: D134138: [libc++][chrono] Implements formatter month..Sep 18 2022, 8:33 AM Mordante removed a parent revision: D134031: [libc++][test] Adds format string helper..Sep 21 2022, 11:12 AM Comment Actions LGTM.
This revision is now accepted and ready to land.Oct 4 2022, 9:13 AM Comment Actions Thanks for the review!
Closed by commit rG3eb4f16b446e: [libc++][chrono] Implements formatter year. (authored by Mordante). · Explain WhyOct 5 2022, 8:01 AM This revision was automatically updated to reflect the committed changes. Mordante removed a child revision: D134138: [libc++][chrono] Implements formatter month..Oct 5 2022, 8:07 AM
Revision Contents
Diff 460298 libcxx/docs/Status/FormatPaper.csv
libcxx/include/__chrono/convert_to_tm.h
libcxx/include/__chrono/formatter.h
libcxx/include/__chrono/ostream.h
libcxx/include/chrono
libcxx/test/libcxx/utilities/format/format.formatter/format.formatter.spec/formattable.compile.pass.cpp
libcxx/test/std/time/time.cal/time.cal.year/time.cal.year.nonmembers/ostream.pass.cpp
libcxx/test/std/time/time.syn/formatter.year.pass.cpp
libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/types.compile.pass.cpp
libcxx/utils/ci/run-buildbot
|
Since this is used in a single place, any reason not to inline it where it's used?