This is an archive of the discontinued LLVM Phabricator instance.

Differential D133527

[mlir][func] Remove unnecessary link dependencies for MLIRFuncTransforms
ClosedPublic

Authored by kuhar on Sep 8 2022, 2:09 PM.

Details

Reviewers
grosser
rriddle
Commits
rG5e5937d05745: [mlir][func] Remove unnecessary link dependencies for MLIRFuncTransforms
Summary

This is so that FuncTransforms can be used by other dialects without introducing cyclic dependencies.

Tested by building with BUILD_SHARED_LIBS=ON

Diff Detail

Event Timeline

kuhar created this revision.Sep 8 2022, 2:09 PM
Herald added a reviewer: grosser. · View Herald TranscriptSep 8 2022, 2:09 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 19 others. · View Herald Transcript
kuhar requested review of this revision.Sep 8 2022, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2022, 2:09 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle accepted this revision.Sep 8 2022, 2:14 PM
This revision is now accepted and ready to land.Sep 8 2022, 2:14 PM
kuhar edited the summary of this revision. (Show Details)Sep 8 2022, 2:16 PM
This revision was landed with ongoing or failed builds.Sep 8 2022, 2:37 PM
Closed by commit rG5e5937d05745: [mlir][func] Remove unnecessary link dependencies for MLIRFuncTransforms (authored by kuhar). · Explain Why
This revision was automatically updated to reflect the committed changes.
kuhar added a commit: rG5e5937d05745: [mlir][func] Remove unnecessary link dependencies for MLIRFuncTransforms.
Harbormaster completed remote builds in B185707: Diff 458860.Sep 8 2022, 3:04 PM

Revision Contents

PathSize
mlir/
lib/
Dialect/
Func/
Transforms/
3 lines

Diff 458878

mlir/lib/Dialect/Func/Transforms/CMakeLists.txt

add_mlir_dialect_library(MLIRFuncTransforms add_mlir_dialect_library(MLIRFuncTransforms
DecomposeCallGraphTypes.cpp DecomposeCallGraphTypes.cpp
FuncBufferize.cpp FuncBufferize.cpp
FuncConversions.cpp FuncConversions.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Func/Transforms ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Func/Transforms
DEPENDS DEPENDS
MLIRFuncTransformsIncGen MLIRFuncTransformsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineDialect
MLIRArithmeticTransforms
MLIRBufferizationDialect MLIRBufferizationDialect
MLIRBufferizationTransforms MLIRBufferizationTransforms
MLIRFuncDialect MLIRFuncDialect
MLIRIR MLIRIR
MLIRMemRefDialect MLIRMemRefDialect
MLIRPass MLIRPass
MLIRSCFDialect
MLIRTransforms MLIRTransforms
) )