This is an archive of the discontinued LLVM Phabricator instance.

Disable MultiSource/UnitTests/C++11/frame_layout on SPARC
ClosedPublic

Authored by ro on Sep 8 2022, 7:30 AM.

Details

Summary

frame_layout.cpp doesn't compile on SPARC (both Solaris/sparcv9 and Linux/sparc64):

FAILED: MultiSource/UnitTests/C++11/frame_layout/CMakeFiles/frame_layout.dir/frame_layout.cpp.o
[...]
fatal error: error in backend: Function "_Z10test_frameILj4096ELb1ELj2048ELb0ELb0EJEEvDpT4_jPKcP13trace_elementd": over-aligned dynamic alloca not supported.
void test_frame<4096u, true, 2048u, false, false>(, unsigned int, char const*, trace_element*, double)

Therefore, this patch disables the test on SPARC.

Tested on sparc64-unknown-linux-gnu (only 3 testsuite failures remaining) and sparcv9-sun-solaris2.11 (11 failures once a couple of Solaris-specific bugs are fixed).

Diff Detail

Repository
rT test-suite

Event Timeline

ro created this revision.Sep 8 2022, 7:30 AM
ro requested review of this revision.Sep 8 2022, 7:30 AM
fhahn added a comment.Sep 8 2022, 7:31 AM

Sounds good to me, but could you file an issue for the failure?

fhahn accepted this revision.Sep 8 2022, 7:40 AM

LGTM, thanks!

Sure, done: Issue #57626.

Would be good to also link to the commit disabling support, so it will get re-enabled once the issue is fixed.

This revision is now accepted and ready to land.Sep 8 2022, 7:40 AM
ro added a comment.Sep 8 2022, 8:02 AM

Would be good to also link to the commit disabling support, so it will get re-enabled once the issue is fixed.

That's difficult because changes are all over the place: the initial enabling landed with the Solaris sanitizer port (both sparc and x86), later parts of compiler-rt were enabled with sparc support disabled. Would take some time do dig up. I'll certainly revert those once someone implements the necessary support.

This revision was automatically updated to reflect the committed changes.

If you filed a bug for the issue, it might be good to refer to it in CMakeLists.txt:)

ro added a comment.Sep 8 2022, 10:46 AM

If you filed a bug for the issue, it might be good to refer to it in CMakeLists.txt:)

True: that's what I did in the committed summary ;-) Just was too lazy to update the review first...