This is an archive of the discontinued LLVM Phabricator instance.

Differential D133467

[BOLT][TEST] Remove functions with dynamic exception specification
ClosedPublic

Authored by Amir on Sep 7 2022, 7:21 PM.

Details

Reviewers
rafauler
maksfb
Group Reviewers
Restricted Project
Commits
rGa80e1e493f33: [BOLT][TEST] Remove functions with dynamic exception specification
Summary

Clang has switched to gnu++17 by default with https://reviews.llvm.org/D131465.
C++17 removes dynamic exception specification. Remove its use as it wasn't
properly tested.

Diff Detail

Event Timeline

Amir created this revision.Sep 7 2022, 7:21 PM
Herald added a reviewer: rafauler. · View Herald TranscriptSep 7 2022, 7:21 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
Amir requested review of this revision.Sep 7 2022, 7:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 7:21 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
Amir added a reviewer: Restricted Project.Sep 7 2022, 7:22 PM
Harbormaster completed remote builds in B185547: Diff 458625.Sep 7 2022, 7:28 PM
Amir updated this revision to Diff 458628.Sep 7 2022, 7:43 PM

Remove filter_only as dynamic exception specification behavior wasn't tested in
BOLT

Amir retitled this revision from [BOLT][TEST] Replace dynamic exception specification with noexcept(false) to [BOLT][TEST] Remove functions with dynamic exception specification.Sep 7 2022, 7:46 PM
Amir edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B185550: Diff 458628.Sep 7 2022, 7:48 PM
maksfb accepted this revision as: maksfb.Sep 7 2022, 8:05 PM
This revision is now accepted and ready to land.Sep 7 2022, 8:05 PM
Closed by commit rGa80e1e493f33: [BOLT][TEST] Remove functions with dynamic exception specification (authored by Amir). · Explain WhySep 7 2022, 8:45 PM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rGa80e1e493f33: [BOLT][TEST] Remove functions with dynamic exception specification.

Revision Contents

PathSize
bolt/
test/
runtime/
X86/
Inputs/
6 lines
6 lines

Diff 458635

bolt/test/runtime/X86/Inputs/exception3.cpp

Show All 10 Lines
void foo(int a) void foo(int a)
{ {
if (a > 1) if (a > 1)
throw ExcG(); throw ExcG();
else else
throw ExcC(); throw ExcC();
} }
void filter_only(int a) throw (ExcA, ExcB, ExcC, ExcD, ExcE, ExcF) {
foo(a);
}
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
asm volatile ("nop;nop;nop;nop;nop"); asm volatile ("nop;nop;nop;nop;nop");
try { try {
try { try {
asm volatile ("nop;nop;nop;nop;nop"); asm volatile ("nop;nop;nop;nop;nop");
throw ExcA(); throw ExcA();
} catch (ExcA) { } catch (ExcA) {
asm volatile ("nop;nop;nop;nop;nop"); asm volatile ("nop;nop;nop;nop;nop");
printf("catch 2\n"); printf("catch 2\n");
throw new int(); throw new int();
} }
} catch (...) { } catch (...) {
asm volatile ("nop;nop;nop;nop;nop"); asm volatile ("nop;nop;nop;nop;nop");
printf("catch 1\n"); printf("catch 1\n");
} }
try { try {
asm volatile ("nop;nop;nop;nop;nop"); asm volatile ("nop;nop;nop;nop;nop");
try { try {
asm volatile ("nop;nop;nop;nop;nop"); asm volatile ("nop;nop;nop;nop;nop");
filter_only(argc); foo(argc);
} catch (ExcC) { } catch (ExcC) {
asm volatile ("nop;nop;nop;nop;nop"); asm volatile ("nop;nop;nop;nop;nop");
printf("caught ExcC\n"); printf("caught ExcC\n");
} }
} catch (ExcG) { } catch (ExcG) {
asm volatile ("nop;nop;nop;nop;nop"); asm volatile ("nop;nop;nop;nop;nop");
printf("caught ExcG\n"); printf("caught ExcG\n");
} }
return 0; return 0;
} }

bolt/test/runtime/X86/Inputs/exception4.cpp

Show All 10 Lines
void foo(int a) void foo(int a)
{ {
if (a > 1) if (a > 1)
throw ExcG(); throw ExcG();
else else
throw ExcC(); throw ExcC();
} }
void filter_only(int a) throw (ExcA, ExcB, ExcC, ExcD, ExcE, ExcF) {
foo(a);
}
void never_throws() throw () { void never_throws() throw () {
printf("this statement is cold and should be outlined\n"); printf("this statement is cold and should be outlined\n");
} }
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
for(unsigned i = 0; i < 1000000; ++i) { for(unsigned i = 0; i < 1000000; ++i) {
try { try {
Show All 10 Lines try {
throw new int(); throw new int();
} }
} catch (...) { } catch (...) {
printf("catch 1\n"); printf("catch 1\n");
} }
try { try {
try { try {
filter_only(argc); foo(argc);
} catch (ExcC) { } catch (ExcC) {
printf("caught ExcC\n"); printf("caught ExcC\n");
} }
} catch (ExcG) { } catch (ExcG) {
printf("caught ExcG\n"); printf("caught ExcG\n");
} }
} }
return 0; return 0;
} }