This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Removes Clang 13 support.
ClosedPublic

Authored by Mordante on Sep 7 2022, 9:55 AM.

Details

Reviewers
ldionne
jloser
Group Reviewers
Restricted Project
Commits
rG3695cf206560: [libc++] Removes Clang 13 support.

Diff Detail

Event Timeline

Mordante created this revision.Sep 7 2022, 9:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 9:55 AM
Mordante requested review of this revision.Sep 7 2022, 9:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 9:55 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante updated this revision to Diff 458519.Sep 7 2022, 10:59 AM

Attempts to fix CI with upstream fix.

ldionne accepted this revision.Sep 7 2022, 1:25 PM
This revision is now accepted and ready to land.Sep 7 2022, 1:25 PM
jloser added a subscriber: jloser.Sep 7 2022, 2:01 PM
jloser added inline comments.
libcxx/test/libcxx/atomics/bit-int.verify.cpp
15–16

Can we remove the apple-clang-13 as well?

ldionne added inline comments.Sep 7 2022, 2:09 PM
libcxx/test/libcxx/atomics/bit-int.verify.cpp
15–16

apple-clang-13 is not related to clang-13 despite the resemblance! Those are different compilers, and I'll work on removing support for that one separately.

Mordante marked an inline comment as done.Sep 8 2022, 8:43 AM

Thanks for the reviews!

libcxx/test/libcxx/atomics/bit-int.verify.cpp
15–16

Thanks @ldionne! You are more familiar with apple-clang than I am.

jloser added inline comments.Sep 8 2022, 8:48 AM
libcxx/test/libcxx/atomics/bit-int.verify.cpp
15–16

Sounds good to me — thanks for the clarification.

jloser accepted this revision.Sep 8 2022, 8:49 AM

LGTM — thanks!

This revision was automatically updated to reflect the committed changes.