Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
| Time | Test | |
|---|---|---|
| 80 ms | x64 debian > LLVM.Analysis/MemorySSA::phi-translation.ll Script:
--
: 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -aa-pipeline=basic-aa -passes='print<memoryssa>,verify<memoryssa>' -disable-output < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Analysis/MemorySSA/phi-translation.ll 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Analysis/MemorySSA/phi-translation.ll --check-prefixes=CHECK,NOLIMIT
|
Event Timeline
Comment Actions
You need to update phi-translation.ll for this change. From a cursory look I think the results improve while still being correct.
| llvm/include/llvm/Analysis/MemorySSA.h | ||
|---|---|---|
| 1258 | A slightly more accurate check would be if (Location.Size != LocationSize::beforeOrAfterPointer()). If the size is already unknown originally, then we don't need to bother with phi translation either. | |
Comment Actions
This is because PerformedPhiTranslation no longer gets set. After looking a bit closer, I think this flag is a leftover from an old implementation. Submitted https://reviews.llvm.org/D133404 to remove.
| llvm/include/llvm/Analysis/MemorySSA.h | ||
|---|---|---|
| 1269 | These codes here seem to make sense. But deleting them would not cause any tests to fail. I think it is necessary to add test cases to cover it. | |