This is an archive of the discontinued LLVM Phabricator instance.

Differential D133346

[mlir] Add materializeOpFoldResults to turn OpFoldResult array into values.
ClosedPublic

Authored by pifon2a on Sep 6 2022, 4:28 AM.

Details

Reviewers
nicolasvasilache
springerm
Commits
rGc141c03fd8c5: [mlir] Add materializeOpFoldResults to turn OpFoldResult array into values.

Diff Detail

Event Timeline

pifon2a created this revision.Sep 6 2022, 4:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 4:28 AM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 19 others. · View Herald Transcript
pifon2a requested review of this revision.Sep 6 2022, 4:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 4:28 AM
Herald added a subscriber: stephenneuendorffer. · View Herald Transcript
springerm accepted this revision.Sep 6 2022, 4:32 AM
This revision is now accepted and ready to land.Sep 6 2022, 4:32 AM
This revision was landed with ongoing or failed builds.Sep 6 2022, 4:38 AM
Closed by commit rGc141c03fd8c5: [mlir] Add materializeOpFoldResults to turn OpFoldResult array into values. (authored by pifon2a). · Explain Why
This revision was automatically updated to reflect the committed changes.
pifon2a added a commit: rGc141c03fd8c5: [mlir] Add materializeOpFoldResults to turn OpFoldResult array into values..
Harbormaster completed remote builds in B185204: Diff 458140.Sep 6 2022, 5:07 AM
nicolasvasilache added inline comments.Sep 6 2022, 6:34 AM
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
952

nit:

ImplicitLocOpBuilder b(loc, builder);
return llvm::to_vector(llvm::map_range(opFoldResults, [&](OpFoldResult ofr){ return (materializeOpFoldResult(b, opFoldResult); }))

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
Linalg/
Utils/
2 lines
lib/
Dialect/
Linalg/
Utils/
10 lines

Diff 458142

mlir/include/mlir/Dialect/Linalg/Utils/Utils.h

Show First 20 Lines • Show All 187 Lines • ▼ Show 20 LinesSmallVector<Value> insertSlicesBack(OpBuilder &builder, Location loc,
ValueRange results); ValueRange results);
/// Turns an OpFoldResult into a value, creating an index-typed constant if /// Turns an OpFoldResult into a value, creating an index-typed constant if
/// necessary. /// necessary.
Value materializeOpFoldResult(ImplicitLocOpBuilder &builder, Value materializeOpFoldResult(ImplicitLocOpBuilder &builder,
OpFoldResult opFoldResult); OpFoldResult opFoldResult);
Value materializeOpFoldResult(OpBuilder &b, Location loc, Value materializeOpFoldResult(OpBuilder &b, Location loc,
OpFoldResult opFoldResult); OpFoldResult opFoldResult);
Value materializeOpFoldResult(OpBuilder &b, Location loc,
ArrayRef<OpFoldResult> opFoldResults);
/// A struct containg offsets-sizes-strides arguments of the tiled shape. /// A struct containg offsets-sizes-strides arguments of the tiled shape.
struct SliceParameters { struct SliceParameters {
SmallVector<OpFoldResult> offsets; SmallVector<OpFoldResult> offsets;
SmallVector<OpFoldResult> sizes; SmallVector<OpFoldResult> sizes;
SmallVector<OpFoldResult> strides; SmallVector<OpFoldResult> strides;
}; };
▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines

mlir/lib/Dialect/Linalg/Utils/Utils.cpp

Show First 20 Lines • Show All 940 Lines • ▼ Show 20 Lines
} }
Value materializeOpFoldResult(OpBuilder &builder, Location loc, Value materializeOpFoldResult(OpBuilder &builder, Location loc,
OpFoldResult opFoldResult) { OpFoldResult opFoldResult) {
ImplicitLocOpBuilder b(loc, builder); ImplicitLocOpBuilder b(loc, builder);
return materializeOpFoldResult(b, opFoldResult); return materializeOpFoldResult(b, opFoldResult);
} }
SmallVector<Value>
materializeOpFoldResults(OpBuilder &builder, Location loc,
ArrayRef<OpFoldResult> opFoldResults) {
ImplicitLocOpBuilder b(loc, builder);
nicolasvasilacheUnsubmitted
Not Done
ReplyInline Actions

nit:

ImplicitLocOpBuilder b(loc, builder);
return llvm::to_vector(llvm::map_range(opFoldResults, [&](OpFoldResult ofr){ return (materializeOpFoldResult(b, opFoldResult); }))
nicolasvasilache: nit: ``` ImplicitLocOpBuilder b(loc, builder); return llvm::to_vector(llvm::map_range…
SmallVector<Value> values;
for (const auto &opFoldResult : opFoldResults)
values.push_back(materializeOpFoldResult(b, opFoldResult));
return values;
}
SmallVector<Optional<SliceParameters>> SmallVector<Optional<SliceParameters>>
computeAllSliceParameters(OpBuilder &builder, Location loc, LinalgOp linalgOp, computeAllSliceParameters(OpBuilder &builder, Location loc, LinalgOp linalgOp,
ValueRange valuesToTile, ArrayRef<OpFoldResult> ivs, ValueRange valuesToTile, ArrayRef<OpFoldResult> ivs,
ArrayRef<OpFoldResult> tileSizes, ArrayRef<OpFoldResult> tileSizes,
ArrayRef<OpFoldResult> sizeBounds, ArrayRef<OpFoldResult> sizeBounds,
bool omitPartialTileCheck) { bool omitPartialTileCheck) {
assert(ivs.size() == static_cast<size_t>(llvm::count_if( assert(ivs.size() == static_cast<size_t>(llvm::count_if(
llvm::make_range(tileSizes.begin(), tileSizes.end()), llvm::make_range(tileSizes.begin(), tileSizes.end()),
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines